Closed Bug 1892841 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 45835 - Always initialize PaintInfo::descendant_painting_blocked_

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45835 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45835
Details from upstream follow.

Philip Rogers <pdr@chromium.org> wrote:

Always initialize PaintInfo::descendant_painting_blocked_

PaintInfo::descendant_painting_blocked_ is a cache of
LayoutObject::ChildPaintBlockedByDisplayLock(), but wasn't being
initialized in BoxFragmentPainter::PaintTextClipMask, which led to
painting locked content. This patch prevents this class of bugs by
forcing descendant_painting_blocked_ to be initialized in the ctor.

Bug: 333952115
Change-Id: Ibea822ba510e1c854d63c5f6dd2b025535498abc
Reviewed-on: https://chromium-review.googlesource.com/5472456
WPT-Export-Revision: d61515605f541f7d212dbede8181981206bd57b2

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ea5e0c45c96 [wpt PR 45835] - Always initialize PaintInfo::descendant_painting_blocked_, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.