1892899 - Prevent IllegalAccessException being thrown in Fenix unit tests

Status: RESOLVED FIXED

(Firefox for Android :: General, task, P1)

Description

[Mihai Adrian Carare [:mcarare]]

This is specific to DefaultSessionControlControllerTest that throws the error for each test ( this points to the code "perpetrator) being in the setup block.

[task 2024-04-22T10:01:30.723Z]     java.lang.IllegalAccessException: class io.mockk.InternalPlatformDsl cannot access a member of class java.io.File (in module java.base) with modifiers "private final"
[task 2024-04-22T10:01:30.724Z]     at java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
[task 2024-04-22T10:01:30.724Z]     at java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)
[task 2024-04-22T10:01:30.724Z]     at java.base/java.lang.reflect.Field.checkAccess(Field.java:1102)
[task 2024-04-22T10:01:30.724Z]     at java.base/java.lang.reflect.Field.set(Field.java:797)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.InternalPlatformDsl.dynamicSetField(InternalPlatformDsl.kt:182)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.impl.recording.states.StubbingAwaitingAnswerState.assignFieldIfMockingProperty(StubbingAwaitingAnswerState.kt:68)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.impl.recording.states.StubbingAwaitingAnswerState.access$assignFieldIfMockingProperty(StubbingAwaitingAnswerState.kt:9)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.impl.recording.states.StubbingAwaitingAnswerState$assignFieldIfMockingProperty$1.invoke(StubbingAwaitingAnswerState.kt:52)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.impl.recording.states.StubbingAwaitingAnswerState$assignFieldIfMockingProperty$1.invoke(StubbingAwaitingAnswerState.kt:51)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.impl.stub.AnswerAnsweringOpportunity.notifyFirstAnswerHandlers(AnswerAnsweringOpportunity.kt:30)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.impl.stub.AnswerAnsweringOpportunity.provideAnswer(AnswerAnsweringOpportunity.kt:21)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.MockKStubScope.answers(API.kt:2226)
[task 2024-04-22T10:01:30.724Z]     at io.mockk.MockKStubScope.returns(API.kt:2230)
[task 2024-04-22T10:01:30.724Z]     at org.mozilla.fenix.home.DefaultSessionControlControllerTest.setup(DefaultSessionControlControllerTest.kt:155)
[task 2024-04-22T10:01:30.724Z]     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[task 2024-04-22T10:01:30.724Z]     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[task 2024-04-22T10:01:30.724Z]     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[task 2024-04-22T10:01:30.724Z]     at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[task 2024-04-22T10:01:30.724Z]     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
[task 2024-04-22T10:01:30.724Z]     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[task 2024-04-22T10:01:30.724Z]     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
[task 2024-04-22T10:01:30.724Z]     at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)
[task 2024-04-22T10:01:30.724Z]     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
[task 2024-04-22T10:01:30.724Z]     at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
[task 2024-04-22T10:01:30.724Z]     at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
[task 2024-04-22T10:01:30.823Z]     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
[task 2024-04-22T10:01:30.823Z]     at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:489)
[task 2024-04-22T10:01:30.823Z]     at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$2(SandboxTestRunner.java:290)
[task 2024-04-22T10:01:30.823Z]     at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:104)
[task 2024-04-22T10:01:30.823Z]     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[task 2024-04-22T10:01:30.823Z]     at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[task 2024-04-22T10:01:30.823Z]     at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[task 2024-04-22T10:01:30.823Z]     at java.base/java.lang.Thread.run(Thread.java:840)

Comment 1

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1892899 - Remove unnecessary mocking of private File path.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e37b2d3cd594
Remove unnecessary mocking of private File path. r=android-reviewers,avirvara

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e37b2d3cd594