Closed
Bug 1893193
Opened 2 years ago
Closed 2 years ago
Using <div>s instead of <message-bar>s for shopping messages regressed icons
Categories
(Firefox Graveyard :: Shopping, defect)
Firefox Graveyard
Shopping
Tracking
(firefox-esr115 unaffected, firefox125 unaffected, firefox126 unaffected, firefox127 fixed)
RESOLVED
FIXED
127 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox125 | --- | unaffected |
| firefox126 | --- | unaffected |
| firefox127 | --- | fixed |
People
(Reporter: hjones, Assigned: hjones)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
The stale, analysis in progress, and re-analysis in progress shopping message bars previously displayed icons that were part of the <message-bar> markup. When switching these messages to <div>s I didn't see the icons (they weren't visible in Storybook...) so overlooked re-implementing them in the new markup - as a result the icons are no longer displayed.
|
Assignee | |
Comment 1•2 years ago
|
||
This patch ensures that the expected icons still display for shopping message bars even though they are no longer using a <message-bar> element under the hood.
|
||
Updated•2 years ago
|
Assignee: nobody → hjones
Status: NEW → ASSIGNED
|
||
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1855471
status-firefox125:
--- → unaffected
status-firefox126:
--- → unaffected
status-firefox127:
--- → affected
status-firefox-esr115:
--- → unaffected
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45ab558752d1
re-implement icons in <div> based shopping message bars r=shopping-reviewers,niklas
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
|
||
Updated•1 year ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•