1893359 - [Flatpak]: Firefox does not set correct DesktopEntry property for MPRIS

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[bbhtt]

Attachment: Screenshot from D-Spy

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

Install GNOME 46/Fedora 40

Play media on Firefox Flatpak from Mozilla

See that the notification does not have the Firefox logo

Actual results:

The DesktopEntry is set to firefox (see attached image)

Expected results:

It should be set to org.mozilla.firefox

Comment 1

[bbhtt]

Attachment: MPRIS without Firefox icon

Comment 2

[bbhtt]

Attachment: MPRIS witH Firefox icon

Comment 3

[bbhtt]

Workaround cp /var/lib/flatpak/exports/share/applications/org.mozilla.firefox.desktop ~/.local/share/applications/firefox.desktop and set NoDisplay=true

Pretty sure this is because of the wrong remoting name again.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[bbhtt]

Pretty sure this is because of the wrong remoting name again.

If I'm reading this right, it's coming from the name of nsIXULAppInfo which is constant to firefox, it should probably be derived from the application ID or the remoting name instead.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Yes, we should use remotingName. But I have no idea where we set that for MPRIS, I can't find that in the code.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1893359 [MPRIS] Use remoting name as desktop entry identifier r?emilio

Comment 8

[bbhtt]

Unfortunately this won't solve the issue for Flatpak builds because it ships the official binary tarballs where the remoting name is firefox. But I guess not much can be done there until the Flatpak is compiled from source like the Snap.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to bbhtt from comment #8)

Unfortunately this won't solve the issue for Flatpak builds because it ships the official binary tarballs where the remoting name is firefox. But I guess not much can be done there until the Flatpak is compiled from source like the Snap.

You may use MOZ_APP_REMOTINGNAME to set remoting name:
https://searchfox.org/mozilla-central/rev/a44891c52387ca4bd7c35b50f0d335f3980ef36a/toolkit/xre/nsAppRunner.cpp#5860

Remoting name has to match desktop file name so it should work correctly as we use the same name for desktop file name and MPRIS desktop ID name, right? If it's broken on flatpak then flatpak may have broken Firefox icon too.

Comment 10

[bbhtt]

You may use MOZ_APP_REMOTINGNAME to set remoting name:
https://searchfox.org/mozilla-central/rev/a44891c52387ca4bd7c35b50f0d335f3980ef36a/toolkit/xre/nsAppRunner.cpp#5860

Oh, I didn't realise it existed in environment variable form too. Then I think it will work.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8397cd70db46
[MPRIS] Use remoting name as desktop entry identifier r=emilio

Comment 12

[Cristian Tuns]

Backed out for causing build bustages in MPRISServiceHandler.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/widget/gtk/MPRISServiceHandler.cpp:419:7: error: use of undeclared identifier 'gAppData'

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de2302e247b0
[MPRIS] Use remoting name as desktop entry identifier r=emilio

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/de2302e247b0