Open Bug 1893458 Opened 2 months ago Updated 1 month ago

No pin notification displayed at first visit of about:welcome after a fresh firefox install

Categories

(Firefox :: Installer, defect)

Firefox 127
Desktop
Windows
defect

Tracking

()

ASSIGNED
Tracking Status
firefox-esr115 --- unaffected
firefox125 --- unaffected
firefox126 --- unaffected
firefox127 --- affected

People

(Reporter: bmaris, Assigned: michaelahughesuk, NeedInfo)

References

Details

(Whiteboard: [fidedi-tabpinning])

Attachments

(2 files)

Found in

  • Latest Nightly 127.0a1

Affected versions

  • Latest Nightly 127.0a1

Tested platforms

  • Affected platforms: Windows 11 Dev and Canary channels only - 24h2 (26080.1 and 26100.1)
  • Unaffected platforms: MacOS and Ubuntu

Preconditions

  • Have a clean Windows with no Firefox installed
  • Clean the Windows is previous Firefoxes were installed by deleting the following:
Delete HKEY_CURRENT_USER\SOFTWARE\Mozilla
Delete HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla
Delete HKEY_LOCAL_MACHINE\SOFTWARE\mozilla.org
Delete HKEY_LOCAL_MACHINE\WOW6432Node\Mozilla
Delete any folder with Mozilla from C:\Program Data
Delete all folders with Mozilla from C:\user\AppData\Local | Roaming | LocalLow

Steps to reproduce

  1. Install latest Nightly (.exe)
  2. Visit about:welcome page
  3. Leave only Pin Nightly to taskbar checked
  4. Click on the Save and continue button

Expected result

  • A system notification is displayed asking the user to pin Firefox to taskbar.

Actual result

  • No notification is displayed
  • The notification will appear if user restarts Nightly and does steps 2-4 again OR by staying in the same session and doing steps 2-4 again.

Regression range

  • Not a regression since this is a new implementation.

Additional notes

  • Gif showing the issue attached

This is known to be a bit inconsistent, I believe due to some issues with the Microsoft APIs we're using. I didn't test with a clean system but I did download the latest version of Nightly and try pinning from about:welcome. Everything worked correctly on my end.

Severity: S2 → S3

This will only be an issue on the newer versions of Windows (Win 11 24H2, unreleased). It's not a priority to fix right now, but will definitely need to be fixed before Win11 24H2 ships. Rollout of that version of Windows will likely start rollout in September, 2024.

This does sound reasonably consistent for QA to reproduce (fails the first time on the newer versions of Windows).

Assignee: nobody → mhughes
Status: NEW → ASSIGNED
Pushed by mhughes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a32d2f7aa06
attempt to fix tab pinning not working sometimes on the first time r=nalexander,nrishel

Backed out for causing build bustages in Windows11TaskbarPinning.cpp

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/browser/components/shell/Windows11TaskbarPinning.cpp(141,19): error: lambda capture 'count' is not used [-Werror,-Wunused-lambda-capture]
Flags: needinfo?(mhughes)

I've kicked off another landing. Setting to needs more information to Nicholas to try to reland it or assign to someone else if it gets rolled back again.

Flags: needinfo?(nrishel)
Flags: needinfo?(mhughes)
Whiteboard: [fidedi-tabpinning]
Pushed by mhughes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfcfe75b775a
attempt to fix tab pinning not working sometimes on the first time r=nalexander,nrishel
Backout by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b7820907458
Backed out 2 changesets (bug 1893458, bug 1890634) for causing bustages at TaskbarPinningMetricsTests.cpp. CLOSED TREE
No longer blocks: 1879975
Depends on: 1879975
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: