1893498 - refactor Phabricator project PHID API calls and storage

Status: NEW

(Conduit :: Lando, enhancement, P3)

Description

[Connor Sheehan [:sheehan]]

Bug 1888188 refactors the blockers/warnings into a more consistent interface. Some of the pieces that were not refactored as part of that bug include our scattered calls to Phabricator to retrieve project PHIDs for various checks. This leaves the new StackAssessmentState with quite a few something_something_phid variables that are all similar.

Since the variables are all related we should group them into a single variable/data type to provide a consistent interface for accessing them. We may also be able to group the requests to the Phabricator Conduit API into a single call, which would give us a performance boost when loading the revision page.

Comment 1

[Liz Henry (:lizzard)]

From discussion today this doesn’t block launch so we’re moving the bug out from under hg to git meta bug and removing it from the project roadmap.