Closed Bug 1893505 Opened 1 year ago Closed 1 year ago

Add custom right-click menu to sidebar extension

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: sclements, Assigned: nsharpley)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(2 files)

For sidebar extensions that are installed and will show up by default once installed (or disappear when removed or disabled), we want to give it its own right-click menu with three options per the spec. I think we can reuse the existing right-click extensions menu (see screenshot).

Assignee: nobody → nsharpley
Attachment #9399262 - Attachment description: WIP: Bug 1893505 - Add custom right-click menu to sidebar extension → Bug 1893505 - Add custom right-click menu to sidebar extension r=#sidebar-reviewers
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd7f1bc5ccce Add custom right-click menu to sidebar extension r=sidebar-reviewers,fluent-reviewers,Gijs,sfoster

Backed out for causing bc failures in browser_sidebar_move.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/sidebar/browser_sidebar_move.js | Correct ordinal (start) - [["","1"],["sidebar-box","2"],["sidebar-splitter","3"],["appcontent","4"]] deepEqual [["sidebar-main",1],["sidebar-box",2],["sidebar-splitter",3],["appcontent",4]] - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/sidebar/browser_sidebar_move.js","name":null,"sourceId":867,"lineNumber":38,"columnNumber":10,"sou
Flags: needinfo?(nsharpley)
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94f7897a0bd0 Add custom right-click menu to sidebar extension r=sidebar-reviewers,fluent-reviewers,Gijs,sfoster
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Flags: needinfo?(nsharpley)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: