1893523 - Add telemetry for when we encounter unplayable HEVC videos

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Jeff Muizelaar [:jrmuizel]]

e.g. visiting https://mylogi.co.jp/wp-content/uploads/2024/04/edaa17a4fd56aac58e6cc039a0a8217e.mp4 on macOS.

I'd like to better understand how often not having HEVC is a web compat problem, so only want to the probe to be triggered when the video is unplayable. If we fallback to another codec it should not trigger.

Comment 1

[Jim Mathies [:jimm]]

We already have this. You can look at requests for support the isTypeSupported telemetry here -

https://sql.telemetry.mozilla.org/queries/94146/source#232707

and you can look at actual consumption on Windows in Nightly for a measure of the amount of hevc content we handle -

https://sql.telemetry.mozilla.org/queries/95278/source#235493

Comment 2

[Jeff Muizelaar [:jrmuizel]]

That telemetry doesn't do what I want. Upon a fresh launch on macOS and going to https://vimeo.com/channels/bestofstaffpicks/900211313 I see:

MSE_SOURCE_BUFFER_TYPE
27 samples, average = 2.1, sum = 56

0 |############## 9 33%
3 |######################### 16 59%
4 |### 2 7%
5 | 0 0%

The video was playable.

Comment 3

[Alastor Wu [:alwu]]

What Jeff wanted is to know how many HEVC video failed to play due to HEVC is unsupported in order to know the web compatibilities. Our current probe can tell how many HEVC videos get played or being asked in MSE, but couldn't tell the amount of that kind of error.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Alastor Wu [:alwu] from comment #3)

What Jeff wanted is to know how many HEVC video failed to play due to HEVC is unsupported in order to know the web compatibilities. Our current probe can tell how many HEVC videos get played or being asked in MSE, but couldn't tell the amount of that kind of error.

Would that show up in payload.processes.content.keyed_scalars.media_decode_error_per_mime_type?

https://sql.telemetry.mozilla.org/queries/93875/source#232165

Comment 5

[Alastor Wu [:alwu]]

(In reply to Jim Mathies [:jimm] from comment #4)

Would that show up in payload.processes.content.keyed_scalars.media_decode_error_per_mime_type?

https://sql.telemetry.mozilla.org/queries/93875/source#232165

No, it won't. That scalar is for any error happening during decoding. For unsupported video type, we won't even start decoding.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1893523 - part1 : if the remote process hasn't started yet, only report HEVC support on Windows when the pref is ON.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1893523 - part2 : add debug logs.

Depends on D210375

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1893523 - part3 : add a Glean metric to record the case where video playback fails due to a not supported type.

Depends on D210376

Comment 9

[Alastor Wu [:alwu]]

Attachment: data-review-request

Comment 10

[Chris H-C :chutten|PTO (back July 13)]

Comment on attachment 9401777 [details]
data-review-request

There's a new data review process in town (for new/expanded data collections landing via Phabricator): https://wiki.mozilla.org/Data_Collection#Firefox_Desktop.2C_Firefox_and_Focus_for_Android.2C_Gecko_.28from_May_7.2C_2024.29

(( Basically, just do what Herald told you on your patchset ))

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83a20bc70352
part1 : if the remote process hasn't started yet, only report HEVC support on Windows when the pref is ON. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/1c9749c706d7
part2 : add debug logs. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/e2cbe5351e93
part3 : add a Glean metric to record the case where video playback fails due to a not supported type. r=media-playback-reviewers,padenot

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/83a20bc70352
https://hg.mozilla.org/mozilla-central/rev/1c9749c706d7
https://hg.mozilla.org/mozilla-central/rev/e2cbe5351e93

Comment 13

[Jim Mathies [:jimm]]

https://sql.telemetry.mozilla.org/queries/100090/source