Closed Bug 189355 Opened 22 years ago Closed 22 years ago

Support <XX> format for emulating IE formatblock

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.3beta

People

(Reporter: mkaply, Assigned: mkaply)

Details

(Whiteboard: midas)

Attachments

(1 file, 1 obsolete file)

See:

http://lxr.mozilla.org/seamonkey/source/content/html/document/src/nsHTMLDocument.cpp#4220

When we first envisioned emulating IE, we were under the impression that
formatblock took english strings like "Paragraph" or "Heading 1".

Upon further investigation, we discovered that these strings changed based on
the language of the browser, so on a Spanish browser, for instance, you are
supposed to use the Spanish word for paragraph.

Luckily, Microsoft provided a language neutral way to accomplish this, by using
the following mapping:

<option value="<P>">Normal</option>
<option value="<PRE>">Formatted</option>
<option value="<ADDRESS>">Address</option>
<option value="<H1>">Heading 1</option>
<option value="<H2>">Heading 2</option>
<option value="<H3>">Heading 3</option>
<option value="<H4>">Heading 4</option>
<option value="<H5>">Heading 5</option>
<option value="<H6>">Heading 6</option>
<option value="<OL>">Numbered List</option>
<option value="<UL>">Bulleted List</option>
<option value="<DL>">Directory List</option>
<option value="<MENU>">Menu List</option>
<option value="<DT>">Definition Term</option>
<option value="<DD>">Definition</option>
<option value="<P>">Paragraph</option>

So for Mozilla, we are ONLY going to support the language neutral method of
passing things to formatblock. We are not going to support the English text. The
only exception will be "normal".

This bug is to convert that table to use the language neutral method.
Hardware: PC → All
Whiteboard: midas
We need this for 1.3b if we are going to finalize the interface. I apologize for
leting this one get away.

Patch coming.
Target Milestone: --- → mozilla1.3beta
Attached patch Emuate <XX> format (obsolete) — Splinter Review
We are supporting the most common commands.
Attachment #112277 - Flags: review?(brade)
Attachment #112277 - Flags: superreview?(peterv)
Attachment #112277 - Flags: review?(brade)
Attachment #112277 - Flags: review+
Attachment #112277 - Attachment is obsolete: true
Comment on attachment 112400 [details] [diff] [review]
Ending double quotes would be helpful

We need this one because we are finalizing Midas docs for 1.3b.
Attachment #112400 - Flags: superreview?(sfraser)
Attachment #112400 - Flags: review+
Comment on attachment 112400 [details] [diff] [review]
Ending double quotes would be helpful

r=brade
Comment on attachment 112400 [details] [diff] [review]
Ending double quotes would be helpful

oh, and don't forget to remove the extra "H3" line (above <pre>)
Comment on attachment 112400 [details] [diff] [review]
Ending double quotes would be helpful

 static struct MidasParam gMidasParamTable[] = {

Make this table const, and sr=sfraser.
Attachment #112400 - Flags: superreview?(sfraser) → superreview+
Comment on attachment 112400 [details] [diff] [review]
Ending double quotes would be helpful

We need this one because we are finalizing Midas docs for 1.3b.

Thanks
Attachment #112400 - Flags: approval1.3b?
Comment on attachment 112400 [details] [diff] [review]
Ending double quotes would be helpful

a=asa (on behalf of drivers) for checkin to 1.3beta.
Attachment #112400 - Flags: approval1.3b? → approval1.3b+
Fix checked in.

Thanks all.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Attachment #112277 - Flags: superreview?(peterv)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: