smil tests use setTimeAndSnapshot onload, bypassing painting invalidation testing of animations
Categories
(Core :: SVG, task)
Tracking
()
People
(Reporter: tnikkel, Unassigned)
References
Details
Most of the tests that use setTimeAndSnapshot (from smil-util.js) call it from the onload handler. This means that it is likely that the first time the page paints is after setTimeAndSnapshot has set the final time on the animation. This means that we never test the painting invalidation of the animation to go from some initial value to the final value. The better thing to do would be to call setTimeAndSnapshot from MozReftestInvalidate (which is called after the initial paint of the page and any pending paints thereafter have been cleared).
This came up in bug 1824502 where this problem was hiding a bug with the in progress patch in the test layout/reftests/svg/smil/anim-feComponentTransfer-01.svg. The problem only showed up intermittently on android. If the test is switched to use MozReftestInvalidate then the problem happens every time, make it much easier to notice problems.
There's 256 occurences of setTimeAndSnapshot in the tree right now.
|
Reporter | |
Updated•9 months ago
|
Description
•