1894067 - Update opus to new version 20568812ae92bb148fe3fb0190b7629f1c4d0b96 from 2024-04-29 17:13:45

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 4 commits, including 3 new upstream commits I've never filed a bug on before. (They're the top 3.). Here are the overall diff statistics, and then the commit information.

---

media/libopus/moz.build | 2 +-
media/libopus/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

20568812ae92bb148fe3fb0190b7629f1c4d0b96 by Jan Buethe <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/20568812ae92bb148fe3fb0190b7629f1c4d0b96
Authored: 2024-04-29 17:13:45 +0200
Committed: 2024-04-29 17:13:45 +0200

README related osce fixes III

Files Modified:

• dnn/torch/osce/README.md

---

f6f2a328a6e315fbb45ad68b43eb8158ded68938 by Jan Buethe <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/f6f2a328a6e315fbb45ad68b43eb8158ded68938
Authored: 2024-04-29 15:58:03 +0200
Committed: 2024-04-29 15:58:03 +0200

README related osce fixes II

Files Modified:

• dnn/torch/osce/README.md

---

fe9ded3bd7d4a8ac04aa6c214405ffcf8ef7b9d2 by Jan Buethe <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/fe9ded3bd7d4a8ac04aa6c214405ffcf8ef7b9d2
Authored: 2024-04-29 15:56:46 +0200
Committed: 2024-04-29 15:56:46 +0200

README related osce fixes

Files Added:

• dnn/torch/osce/scripts/concatenator.py

---

0dc559f060db0d62d95f424e3fd26a5f673b2f6b by Jan Buethe <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/0dc559f060db0d62d95f424e3fd26a5f673b2f6b
Authored: 2024-04-24 12:17:51 +0200
Committed: 2024-04-24 12:17:51 +0200

added some bwe-related stuff

Files Added:

• dnn/torch/osce/losses/td_lowpass.py
• dnn/torch/osce/silk_16_to_48.py
• dnn/torch/osce/utils/layers/fir.py

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=07cd475d9478137ce9837cbef9202c9689b135a6

Comment 3

[Update Bot]

Attachment: Bug 1894067 - Update opus to 20568812ae92bb148fe3fb0190b7629f1c4d0b96

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• browser/components/urlbar/tests/browser/browser_switchTab_inputHistory.js
  • 2 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (IRaKWja0QfqCJqJtasEdRA)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (cdkNfvmIQu6Hz0lxrTlycQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libopus/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Matthew Gregan [:kinetik]]

Trivial update, no functional changes. Queued for landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78b88eeb6351
Update opus to 20568812ae92bb148fe3fb0190b7629f1c4d0b96 r=kinetik DONTBUILD

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/78b88eeb6351