1894218 - Code coverage false negatives

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Geoff Lankow (:darktrojan)]

About a week ago the code coverage score dropped quite a bit, and lots of code we know to have test coverage was listed as not covered. I assume this has been triggered by some change to the core code, but as with previous false-negatives, it's because some window objects are not being released properly and never record their coverage data. I've managed to trace this back to some faulty code in the folder quota display, which adds a TabSelect listener and never removes it.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1894218 - Clear event listener when about:3pane window is unloaded. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1c39d7ab86a0
Clear event listener when about:3pane window is unloaded. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

There must be more to this, because while that patch fixed some things, we're still missing coverage data that should exist. I'm not overly surprised, just disappointed. I'm going to reuse this bug to continue hunting.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1894218 - Stop browser_preferDisplayName.js breaking code coverage by waiting for messages to load. r=aleca

We're missing a bunch of coverage data if the test finishes before the message loads. The data is not
from the loading window, but one of its ancestors, so I'm not entirely sure what's going on here.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/46e94949ddf9
Stop browser_preferDisplayName.js breaking code coverage by waiting for messages to load. r=aleca