Closed Bug 1894231 Opened 2 years ago Closed 2 years ago

Remove WorkPrivate raw pointers which are a class member variable.

Categories

(Core :: DOM: Workers, task, P2)

task

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: edenchuang, Assigned: edenchuang)

References

Details

Attachments

(11 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

WorkerPrivate* should be replaced with RefPtr<WorkerPrivate> or using ThreadSafeWorkerRef as a class member.

Assignee: nobody → echuang
Severity: -- → S3
Priority: -- → P2
Attachment #9404297 - Attachment description: WIP: Bug 1894231 - Remove CheckedUnsafePtr<WorkerPrivate> of WebTaskSchedulerWorker. r=#dom-worker-reviewers → Bug 1894231 - Remove CheckedUnsafePtr<WorkerPrivate> of WebTaskSchedulerWorker. r=#dom-worker-reviewers
Attachment #9405505 - Attachment description: Bug 1894231 - P2 Remove WorkerPrivate* in WorkerMainThreadRunnable. r=#dom-worker-reviewers → Bug 1894231 - P3 Remove WorkerPrivate* in WorkerMainThreadRunnable. r=#dom-worker-reviewers
Pushed by echuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab29ecd0d051 Remove CheckedUnsafePtr<WorkerPrivate> of WebTaskSchedulerWorker. r=dom-worker-reviewers,smaug https://hg.mozilla.org/integration/autoland/rev/87bc2a8a380e P2 Remove CheckedUnsafePtr<WorkerPrivate> in AutoSyncLoopHolder and AutoPushEventLoopGlobal. r=dom-worker-reviewers,smaug https://hg.mozilla.org/integration/autoland/rev/4817054a7620 P3 Remove WorkerPrivate* in WorkerMainThreadRunnable. r=dom-worker-reviewers,extension-reviewers,smaug,rpl https://hg.mozilla.org/integration/autoland/rev/bb66a5c8b1bc P4 Remove XMLHttpRequestWorker::mWorkerPrivate. r=dom-worker-reviewers,smaug https://hg.mozilla.org/integration/autoland/rev/0cdb2b0b8bc8 P5 Remove XMLHttpRequestWorker's Proxy::mWorkerPrivate. r=dom-worker-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/bcc5d9d02ec4 P6 Remove ScriptResponseHeaderProcessor::mWorkerPrivate. r=dom-worker-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/85a5ea86dc1f P7 Remove mozJSModuleLoader::ScriptReaderRunnable::mWorkerPrivate. r=dom-worker-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/81ff2e3432c1 P8 Remove ImageBit::SendShutdownToWorkerThread::mWorkerPrivate. r=dom-worker-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/2a4f40e22e13 P9 Remove FileReaderSync ReadCallback::mWorkerPrivate. r=dom-worker-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/bb302697f033 P10 Remove ServiceWorkerEvent WaitUntilHandler::mWorkerPrivate. r=dom-worker-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/b7d4fb0fcc54 P11 Remove WorkerThreadRunnable::mWorkerPrivateForPreStartCleaning. r=dom-worker-reviewers,asuth
Regressions: 1905337
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: