Remove `skip-if = condprof` added for Bug 1875480
Categories
(WebExtensions :: General, task, P3)
Tracking
(firefox127 fixed)
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: rpl, Assigned: rpl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In Bug 1875480 we are introducing a new API method (runtime.getContexts) and a new string enum (runtime.ContextTypes) to the runtime API namespace and so we had to add a skip-if to an xpcshell test that would be hitting a condprof job failure due to the API schema cached in the conditioned profile not including these new definitions yet.
This bug is tracking removing that skip-if a few days after Bug 1875480 patch have been merged to mozilla-central and the conditioned profile regenerated.
Bug 1769184 tracks looking into avoiding adding and removing a condprof skip-if on the tests that hits this kind of failure.
|
Assignee | |
Comment 1•5 months ago
|
||
Depends on D207865
|
|
Assignee | |
Comment 2•5 months ago
|
||
Follows the stack trace of the error that would be hit without the skip-if with the current version of the conditioned profiles (tested locally on Linux with the command: mach xpcshell-test toolkit/components/extensions/test/xpcshell/test_ext_runtime_getContexts.js --conditioned-profile):
2:06.07 FAIL test_runtime_getContexts - [test_runtime_getContexts : 100] Got the expected error message - "TypeError: browser.runtime.getContexts is not a function" == "Error: Incorrect argument types for runtime.getContexts."
/home/rpl/my/mozlab/mc-trypush/obj-artifact-opt/_tests/xpcshell/toolkit/components/extensions/test/xpcshell/test_ext_runtime_getContexts.js:test_runtime_getContexts:100
/home/rpl/my/mozlab/mc-trypush/testing/xpcshell/head.js:_do_main:245
/home/rpl/my/mozlab/mc-trypush/testing/xpcshell/head.js:_execute_test:596
-e:null:1
|
||
Comment 4•5 months ago
|
||
| bugherder | ||
Description
•