1894345 - [Android Large Screen Ready Tier 3] Camera view stretched and sideways. (search bar> click QR scanner icon)

Status: RESOLVED FIXED

(Firefox for Android :: QR, defect, P2)

Description

[Chris Peterson [:cpeterson]]

App should provide camera preview in landscape and portrait orientations, folded and unfolded device states, and multi-window mode. Preview is properly proportioned and in the correct orientation

See guideline ID LS-CM1 and test T3-7 on:

https://developer.android.com/docs/quality-guidelines/large-screen-app-quality#large_screen_ready

Comment 1

[Noah Bond [:007]]

I spent some time today investigating this.

• This looks low to moderate effort and viable within a release cycle.
  • It should NOT require any major, upfront technical refactoring.
• Lead time for implementation
  • Best case - 1 week
  • Worst case - 2 to 3 weeks
• The code path to update the orientation is very likely not being called in this use case, so it could be as simple as making sure lifecycle events (like folding/unfolding) are being properly handled during the re-draw.
  • Recommend investigating the code path starting here

Note: If this is a feature we’d like to long term support or enhance, we should consider this area for some technical refactoring at a later date.

Comment 2

[Noah Bond [:007]]

Attachment: Bug 1894345 - Ensure the QR scanner properly redraws after configuration changes

The TextureView inside of QrFragment was ignoring configuration changes that weren't Window resizes.

This was confirmed by having Fenix as a windowed application on a tablet. The QR scanner worked as expected when rotating the device while fullscreen, but it would not redraw & reorient the camera surface when rotating then device while as a PiP app.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7428254120e
Ensure the QR scanner properly redraws after configuration changes r=android-reviewers,tthibaud

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c7428254120e

Comment 5

[Noah Bond [:007]]

QE - could you please do a quick validation pass here (whenever this is in Nightly) to confirm the QR scanner correctly works in the following scenarios:

• Phones
• Tablets/Foldables (with Fenix fullscreen)
• Tablets/Foldables (with Fenix as a picture in picture window)
• Tablets/Foldables (with Fenix open in split screen with another app)
• Foldables (folding and unfolding the device with the scanner open)

I originally triggered the bug while having Fenix as a picture in picture window, opening the QR scanner, and then rotating the device. In this scenario, the QR scanner was not redrawing its UI and was not re-orientating the camera, making the camera view off by 90 degrees after a rotation.

Comment 6

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: az_recorder_20240531_145933.mp4

The QE team performed some testing around QR scanner on latest Firefox Nightly 128 (2024-05-31) and the testing results are listed below:

• Phones : No issues - Tested on Samsung Galaxy A32 (Android 13), Samsung Galaxy A13 (Android 12) and Oppo Fin X3 Neo (Android 11)
• Tablets/Foldables (with Fenix fullscreen): No issues - Tested on Samsung Galaxy Tab S8 Ultra (Android 12), Huawei MediaPad T5 (Android 8) and Samsung GalaxyZ Fold 4 (Android 14)
• Tablets/Foldables (with Fenix as a picture in picture window): The initial issue is still reproducible on Samsung devices, the camera preview maintains its first orientation and it's not updated according to the device position. Reproducible on Samsung Galaxy Tab S8 Ultra (Android 12) and Samsung GalaxyZ Fold 4 (Android 14)
• Tablets/Foldables (with Fenix open in split screen with another app): No issues - Tested on Samsung Galaxy Tab S8 Ultra (Android 12), Huawei MediaPad T5 (Android 8) and Samsung GalaxyZ Fold 4 (Android 14)
• Foldables (folding and unfolding the device with the scanner open): No issues - Samsung GalaxyZ Fold 4 (Android 14)

I am attaching a video with the camera orientation issue that was reproduced on Firefox Nightly 128 (2024-05-31) using Samsung Galaxy Tab S8 Ultra (Android 12).