1894373 - Setting DisableSecurityBypass->Safebrowsing to false should should remove the "Allow download" button

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[ivxdxitbqizbcasgfc]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

With the policy DisableSecurityBypass SafeBrowsing being True and SafeBrowsing downloads enabled. Download the following file:
https://testsafebrowsing.appspot.com/s/content.exe

Actual results:

The allow download button still appears for a download that is blocked by safebrowsing such as:
https://testsafebrowsing.appspot.com/s/content.exe

Expected results:

The allow download button should be disabled or removed.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mike Kaply [:mkaply]]

Sorry, I'm not understanding.

I'm able to download these files with no issues on Firefox.

Should I see a warning?

Can you post screenshots of what you see?

Comment 3

[Mike Kaply [:mkaply]]

Sorry, I get this now.

The SafeBrowsing policy is only related to web browsing, not downloads.

We don't have a way to remove that button.

But you raise a good question. Should that policy remove the Allow download button.

I think you're probably right, that makes sense.

Or we should add another policy.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Bug 1894373 - Hide "Allow download" when SafeBrowsing override is disabled. r?emz:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0ddaa02d1047
https://hg.mozilla.org/integration/autoland/rev/78d410156c20
Hide "Allow download" when SafeBrowsing override is disabled. r=mak:

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/78d410156c20