1894459 - Upgrade Firefox 128 to use NSS 3.101

Status: RESOLVED FIXED

(Core :: Security: PSM, task, P1)

Description

[Dennis Jackson]

Note: This is also an ESR Release.

Comment 1

[Anna Weine]

Attachment: Bug 1894459 - land NSS NSS_3_101_BETA1 UPGRADE_NSS_RELEASE, r=#nss-reviewers

Comment 2

[Kai Engert [:KaiE:]]

Prior to landing a snapshot that includes bug 1884444, please check that tests don't crash in the NSS_Shutdown assertion.
(Probably needs an incremental patch to fix leaks in bug 1884444.)

Comment 3

[Kai Engert [:KaiE:]]

The current tip of NSS, when used with mozilla-central, leads to a shutdown down crash in the following tests:
toolkit/mozapps/extensions/test/xpcshell/test_ProductAddonChecker_signatures.js
security/manager/ssl/tests/unit/test_content_signing.js

The problem happens when the following block of code is executed:
https://searchfox.org/mozilla-central/source/security/manager/ssl/ContentSignatureVerifier.cpp#369-402

The problem is unrelated to bug 1884444, (my earlier claim in comment 2 was wrong).

Comment 4

[Anna Weine]

Attachment: Bug 1894459 - land NSS NSS_3_101_BETA2 UPGRADE_NSS_RELEASE, r=#nss-reviewers

Comment 5

[Anna Weine]

Hey, I was trying to uplift the code today, and I get a lot of problems:

https://treeherder.mozilla.org/jobs?repo=try&revision=6ba02f7b0c95a5a2fc9d18439a1a64dfcec2acd0.

Specifically, I see this: error: undefined symbol: HASH_GetHashOidTagByHMACOidTag_Util

Have we missed landing some code?

Comment 6

[Kai Engert [:KaiE:]]

Anna, Firefox attempts to minimize the code that is shipped in the shared NSS libraries, and uses some tricks to do that.
There is a file ./security/nss.symbols in the mozilla-central tree that lists all the symbols that Firefox needs and must be included.
Please try adding that function to that file.

Comment 7

[John Schanck [:jschanck]]

Attachment: Bug 1894459 - land NSS a4c9d2760c66 UPGRADE_NSS_RELEASE, r=keeler

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c588d7b9438
land NSS a4c9d2760c66 UPGRADE_NSS_RELEASE, r=keeler

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9c588d7b9438

Comment 10

[Anna Weine]

Attachment: Bug 1894459 - land NSS NSS_3_101_RTM UPGRADE_NSS_RELEASE, r=#nss-reviewers

Comment 11

[Anna Weine]

Attachment: Bug 1894459 - land NSS NSS_3_101_RTM UPGRADE_NSS_RELEASE, r=#nss-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0ee6408f6b8
land NSS NSS_3_101_RTM UPGRADE_NSS_RELEASE, r=nss-reviewers,jschanck

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c0ee6408f6b8