Closed Bug 1894619 Opened 7 months ago Closed 7 months ago

need to remove the invalid regex escape sequence `\/` from the .hgignore

Categories

(Developer Infrastructure :: Mach Vendor & Updatebot, defect)

defect

Tracking

(firefox127 fixed)

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: alphare33, Assigned: tjr)

Details

Attachments

(1 file)

Steps to reproduce:

Run RUST_LOG=trace rhg st, with rhg being the pure-Rust version of Mercurial or hg with the Rust extensions installed.

Actual results:

RUST_LOG=trace rhg st will show rhg falling back to plain hg with an error containing the entire regex compiled from the .hgignore along with the message:

Rust status fallback: `Unsupported syntax regex parse error
[...]
error: unrecognized escape sequence`.

Expected results:

The Rust code should not have fallen back, and the execution should have been much faster.

This is motivated by https://hg.mozilla.org/mozilla-central/rev/51489f639f64, whose effect is not possible to observe since https://hg.mozilla.org/mozilla-central/rev/9019d5912d58 has introduced \/ escape sequences. I will send a patch to fix this.

The .gitignore was corrected in b385fda59641, but not the .hgignore.

Pushed by cosheehan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c792c2a60fa Remove the invalid regex escape sequences in .hgignore. r=sheehan
Status: UNCONFIRMED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: