Closed Bug 189462 Opened 22 years ago Closed 22 years ago

trunk build fails to launch wih old GRE installed

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: tracy, Assigned: dougt)

Details

(Keywords: smoketest)

Attachments

(2 files)

add MOZILLA_VERSION to mozilla-config & export nsBuildID.h to SDK
4.17 KB, patch
Details | Diff | Splinter Review
quick fix for cfm
444 bytes, patch
mikepinkerton
: review+
peterv
: superreview+
Details | Diff | Splinter Review 
seen with build 2002-01-17-04-trunk

-install the noted build
-launch the build
attempts to launch the build fail. 

Note: I am able to install this build on windows98
I build on win2k, so I'll pull and rebuild and see if I can reproduce this.
Marina was able to install this on her win2k machine.  
Were the builds that do install and don't install at different times?  There was
a good bit of bustage this morning so some builds may be broken, but the 8am
builds should be better than some earlier ones.
I installed the same build on all the different machines.  Marina used the same
build also. The build passed the smoketests on win98. This is looking more like
something wacked on my machine. :-/  I'll reduce for now.  If someone else can
reproduce it, please change back to smoketest blocker.
Severity: blocker → critical
Keywords: regression, smoketest
dougt, could this be your checkins from y'day?
I can install yesterdays build that was smoketest (2003-01-16-04-trunk) Todays 8
am  depend build won't launch.  doesn't seem like my machine since I can launch
yesterdays build.

this is probably my bug...  It may be a packaging issue.... I will check it out.
Assignee: asa → dougt
what about the other platforms?  do we know if they work?
removing the GRE config files/registry entries from my machine fixes this.

tracy - were you testing with SSU's GRE installer?
yep, removing the gre solves the problem.  the build launches fine.


marking as a blocker.
Severity: critical → blocker
oops, was this just an issue with something twalker did on his machine?  
yup.

But I wanna make sure that this can't happen again.

this is NOT a blocker.
Severity: blocker → critical
did Great America open early?  what a ride!!! :-)
Keywords: smoketest
changed description to reflect why it doesn't launch.

dougt, why hadn't this happened until today? I've been doing mfcembed testing
using the GRE installer for quite some time now.  Will installing the GRE again
break the trunk build?
Summary: trunk build fails to launch on win 2k → trunk build fails to launch wih GRE installed
that summary isn't quite correct.  but whatever.  
a guess would be that the current GRE on the trunk is setting itself up as 1.3a,
while dougt's patch is looking for 1.3b....?  something that happened in the my
test builds.
nope.

The mozilla clients finds a nightly build of the GRE install.  We need to change
the key which the client looks for to include the build id so that we know
exactly which version of the GRE we are getting....  Lets talk.
ssu - we need to be checking more than just the milestone on the GRE version...
it should be something like check the GRE version AND the build date.
Severity: critical → major
Summary: trunk build fails to launch wih GRE installed → trunk build fails to launch wih old GRE installed
right. When the GRE bits (at least one of them) have the
major.minor.build.release versions all figured out (bug 180383), we could have
the bootstrap code do an additional check for the file version.

or were you thinking of something else for right now?
that is exactly what i was thinking.  I need this value to be stuck in some
header file during the build so that my code can read it in.  I am sure that you
will need something similar.  Is this what you have going right now?

mine code is not hooked up to look at any header file right now (but it should
in the future).  however, it does have to code to verify that a file exists
(that belongs to GRE) and also try to get at its file version info structure.

The only part that needs to be done is hook up the installer's build process to
automatically pickup the GRE file's version info, which shouldn't be difficult.
A question on this bug.
I use Win2k and since a trunk build after 2003-01-16 I can install it but if I
try to launch Mozilla it apears only for a micron in the Task-Manager in every
trunk build since then.
Has that to do with this bug?

cls - works fine.  check it in! :-)

(of course ssu and I have to hook up our end of the fix to be able to close out
this bug)
Totally broken on CFM. MOZILLA_VERSION is undefined.
windows commercial trunk build 2003-01-22-04-trunk fails to launch.  

I'm fairly certain that there is no longer a gre on this machine.  I haven't
installed the gre since removing it on Friday. 

This is blocking smoketesting.
Severity: major → blocker
Keywords: smoketest
Actually, it's bug 189992 that breaks Mac.
I'd guess this is from 186703
Argh.  Haven't we killed CFM yet?
Comment on attachment 112302 [details] [diff] [review]
quick fix for cfm

r=pink
Attachment #112302 - Flags: review+
Comment on attachment 112302 [details] [diff] [review]
quick fix for cfm

This will fix the bustage. Ugly but it's almost dead anyway I guess.
Attachment #112302 - Flags: superreview+
Can someone check in the patch so I can respin the build?  Thanks
Checking in config/mac/DefinesMozilla.h;
/cvsroot/mozilla/config/mac/DefinesMozilla.h,v  <--  DefinesMozilla.h
new revision: 1.36; previous revision: 1.35
done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
verified fixed with windows commercial trunk build 2003-01-22-10-trunk
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: