1894645 - No rule to make target 'libxul.so', needed by 'gtest'. Stop.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:gerard-majax]

This has started recently.

STR:

1. mach build finishes fine
2. mach gtest

Expected:
Builds and run gtest

Actual:
Fails with 0:01.12 gmake[1]: *** No rule to make target 'libxul.so', needed by 'gtest'. Stop.

Locally reverting bug 1459764 fixes the issue.

Comment 1

[:gerard-majax]

Adding ac_add_options --enable-gtest-in-build does NOT improve anything. (except the error is now gmake: *** No rule to make target 'recurse_gtest'. Stop.)

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1459764

:glandium, since you are the author of the regressor, bug 1459764, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

What's your mozconfig? This works for me...

Comment 4

[:gerard-majax]

Are you looking for something specific? I really have nothing special and it has been working for years

Comment 5

[Emilio Cobos Álvarez [:emilio]]

I lie, I can repro, I expected the error message right away but it's all the way to the end of the build...

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1894645 - Adjust non-default-target case after bug 1459764.

We changed the SHARED_LIBRARY, so we need to adjust the non-default-target
associated with it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf233107a68e
Adjust non-default-target case after bug 1459764. r=firefox-build-system-reviewers,nalexander

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cf233107a68e