1894666 - CSS Custom Highlight API: Call `NotifySelectionListener()` with the correct Selection type

Status: RESOLVED FIXED

(Core :: DOM: Selection, task)

Description

[Jan Jaeschke [:jjaschke]]

Currently, adding/removing highlight selections calls Selection::NotifySelectionListener() using nsFrameSelection::EndBatchChanges(), but for SelectionType::eNormal instead of SelectionType::eHighlight.

My assumption here is that this might trigger unnecessary a11y or IME listeners, which could be the reason for Bug 1892216. Bug 1892589 contains an abandoned wip patch to fix this, however this patch unexpectedly failed some tests, so let's continue the work for this in here.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1894666 - Custom Highlight API: Call `NotifySelectionListener()` for the correct selection type. r=masayuki!,#dom-core

Before this patch, the AutoFrameSelectionBatcher helper class would always call NotifySelectionListeners() for SelectionType::eNormal, even if the selection may have originated from Custom Highlight. This could have triggered unnecessary code leading to poorer performance.

Comment 2

[Jan Jaeschke [:jjaschke]]

Here's a try run.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e994fa43d2ab
Custom Highlight API: Call `NotifySelectionListener()` for the correct selection type. r=masayuki,dom-core

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e994fa43d2ab