Closed
Bug 1894763
Opened 1 year ago
Closed 1 year ago
Get all reader view prefs using a try-catch block
Categories
(Toolkit :: Reader Mode, enhancement)
Toolkit
Reader Mode
Tracking
()
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: ini, Assigned: ini)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
blocker level bug for rolling out new theme and layout menus.
Currently, if an invalid value is passed to one of the Reader View pref getters, it stops AboutReader.sys.mjs from executing and makes reader view inaccessible. We should refactor the code by declaring all pref values using the default values first, then attempt to fetch the pref value in a try catch block, logging a warning if an invalid value is passed.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → ini
Status: NEW → ASSIGNED
Pushed by ini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d166b88c4f9
Get all reader view prefs using a try-catch block. r=reader-mode-reviewers,Gijs
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•