189489 - hook up Help buttons for Junk Mail and Message Views dialogs

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[robinf]

Help buttons must be hooked up to help for the following new dialogs:

Customize Message Views
Message View Setup
Junk Mail Controls

I'll provide the context id's that you can use to hook these up to help.

Comment 1

[Samir Gehani]

Mail triage team: nsbeta1+/adt1

Comment 2

[robinf]

Please use these description ID's:

Customize Message Views dialog Help button: message-views-using
Message View Setup dialog Help button: message-views-create-new
Junk Mail Controls dialog Help button: mail-junk-controls

I'll add a note in this bug once I've updated the help content and help-toc.rdf
with these new ID's.

Comment 3

[robinf]

Checked in to NS trunk: updated mail help content and help-toc.rdf files to use
these description IDs. 

Comment 4

[robinf]

Just to clarify: all description id's should point to //help/locale/mail_help.html. 

Comment 5

[robinf]

*** Bug 191200 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

accepting, should be a quick fix.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: testing this patch now...

Comment 8

[(not reading, please use [e-mail] instead)]

updated patch coming, but question for robinf:

did you check in the help file changes to the ns tree, or the mozilla tree?

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

Comment 10

[(not reading, please use [e-mail] instead)]

I checked, and it looks like the changes to help were only made for the ns tree.

this feature is in both moz and ns.

how does help work?  do you have to make the changes to both places, or do you
make the change to the mozilla side, and ns gets it for free?

Comment 11

[(not reading, please use [e-mail] instead)]

ok, I verified the patch works (and goes to the placeholders) on the ns tree,
but we need similar place holders for mozilla.

Comment 12

[robinf]

Seth, I will take care of the help file updates to the mozilla tree, now that
you've hooked up the Help buttons in these three dialogs. The way
help works is that we periodically refresh the mozilla tree with the latest help
content from the ns tree. I realize that I need to do that in order for QA to be
able to verify that this bug is fixed.

Comment 13

[(not reading, please use [e-mail] instead)]

Comment on attachment 113225 [details] [diff] [review]
updated patch

r/sr=bienvenu over aim.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 113225 [details] [diff] [review]
updated patch

a=asa (on behalf of drivers) for checkin to 1.3beta

Comment 15

[(not reading, please use [e-mail] instead)]

I've checked in, re-assign to robinf to track the issue of landing the help
stubs to the moz tree.

Comment 16

[robinf]

updates checked in to mozilla trunk.

Comment 17

[esther]

Using trunk build 20030228 on winxp, mac osx and linux this is hooked up.