189494 - 'var frames;' can be declared, but does not override Document.frames (was: Comes up with blank screen)

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Dick Boogaers]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021212

The page http://www.neder-l.nl takes almost no time to load. It comes up blank.
It should come up with general info about the site.

Reproducible: Always

Steps to Reproduce:
1. Go to URL http://www.neder-l.nl
2.
3.

Actual Results:  
Blank screen

Expected Results:  
SHould have shown general information about the site Neder-l

Comment 1

[Ruslan Ismailov]

This cite use variable frames in a way of:

var frames = '<FRAMESET ROWS="70,*">'

(this assignement could not be executed).

Comment 2

[Wesha]

Fixed on January 10th, 2003. Please download a newer build.


*** This bug has been marked as a duplicate of 187790 ***

Comment 3

[Olivier Cahagne]

confirming using build 20030117 on Linux.

Comment 4

[Wesha]

Hmmm.... further investigation shows that there's more in this bug than that.
Changins summary and reopening.

The problem is, 

var frames = '<FRAMESET ROWS="70,*">'

is supposed to define local variable called "frames" and assign value to it.
Instead, we get the error:

-----------------------------------------
Error: setting a property that has only a getter
Source File: http://www.neder-l.nl/
Line: 54
-----------------------------------------

While we should either
a) let them do so because the variable name overrides property name in this
scope, or
b) complain that the variable defined uses a reserved word (property name), etc.

Comment 5

[Dick Boogaers]

I sure hope you're not going to deviate from what 90% of the browser users 
expect: to see a page when they select it's URL. So, not handling this as an 
error is, imho, the only way.

Comment 6

[Phil Schwartau]

|frames|, i.e. |window.frames|, is an in-built DOM object,
not a JS Engine object.

---> DOM Level 0

Comment 7

[Johnny Stenback (:jst)]

Attachment: Make window.frames replaceable.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 113541 [details] [diff] [review]
Make window.frames replaceable.

got r=fabian over email.

He had just one comment:
Please add 'This property is "replaceable" in JavaScript' in a comment in
nsIDOMJSWindow or in nsIDOMWindow or in both.

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 113541 [details] [diff] [review]
Make window.frames replaceable.

This is a lowrisk fix that would make more websites work (although most likely
not a huge number). Should be absolutely safe for 1.3final.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 113541 [details] [diff] [review]
Make window.frames replaceable.

a=asa (on behalf of drivers) for checkin to 1.3 final.

Comment 11

[Johnny Stenback (:jst)]

FIXED. Added a comment to nsIDOMJSWindow.idl as well.

Comment 12

[Wesha]

Verified fixed 2003021908/NT4. The example site is now properly displayed. Yay!