1894995 - Remove deprecated nsICacheEntry methods

Status: RESOLVED FIXED

(Core :: Networking: Cache, task, P3)

Description

[Valentin Gosu [:valentin]]

These methods were used by the previous cache implementation and are no longer required.
We can remove them from the interface and their implementations.

Comment 1

[Sean Kim [:sekim]]

Attachment: Bug 1894995 - Remove deprecated nslCacheEntry methods and their implementations r?valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8abbf422db5c
Remove deprecated nslCacheEntry methods and their implementations r=valentin,necko-reviewers

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on nsHttpChannel.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/83df047ffc0096eefc44970755508262c8594e79
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=8abbf422db5c4e71f0254068906e718fb134aacd
• failure log: https://treeherder.mozilla.org/logviewer?job_id=458584335&repo=autoland&lineNumber=88723

[task 2024-05-17T09:47:18.459Z] 09:47:18     INFO -  In file included from Unified_cpp_protocol_http4.cpp:56:
[task 2024-05-17T09:47:18.459Z] 09:47:18    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:951:29: error: too many arguments to function call, expected 0, have 1
[task 2024-05-17T09:47:18.459Z] 09:47:18     INFO -    951 |     Unused << ReadFromCache(true);
[task 2024-05-17T09:47:18.459Z] 09:47:18     INFO -        |               ~~~~~~~~~~~~~ ^~~~
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.h:404:26: note: 'ReadFromCache' declared here
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -    404 |   [[nodiscard]] nsresult ReadFromCache(void);
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -        |                          ^
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -  In file included from Unified_cpp_protocol_http4.cpp:56:
[task 2024-05-17T09:47:18.461Z] 09:47:18    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:983:26: error: too many arguments to function call, expected 0, have 1
[task 2024-05-17T09:47:18.461Z] 09:47:18     INFO -    983 |       rv = ReadFromCache(true);
[task 2024-05-17T09:47:18.461Z] 09:47:18     INFO -        |            ~~~~~~~~~~~~~ ^~~~
[task 2024-05-17T09:47:18.461Z] 09:47:18     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.h:404:26: note: 'ReadFromCache' declared here
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -    404 |   [[nodiscard]] nsresult ReadFromCache(void);
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -        |                          ^
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -  In file included from Unified_cpp_protocol_http4.cpp:56:
[task 2024-05-17T09:47:18.462Z] 09:47:18    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:3597:39: error: too many arguments to function call, expected 0, have 1
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -   3597 |     nsresult rv = self->ReadFromCache(false);
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -        |                   ~~~~~~~~~~~~~~~~~~~ ^~~~~

Comment 4

[Sean Kim [:sekim]]

(In reply to Natalia Csoregi [:nataliaCs] from comment #3)

Backed out for causing bustage on nsHttpChannel.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/83df047ffc0096eefc44970755508262c8594e79
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=8abbf422db5c4e71f0254068906e718fb134aacd
• failure log: https://treeherder.mozilla.org/logviewer?job_id=458584335&repo=autoland&lineNumber=88723

[task 2024-05-17T09:47:18.459Z] 09:47:18     INFO -  In file included from Unified_cpp_protocol_http4.cpp:56:
[task 2024-05-17T09:47:18.459Z] 09:47:18    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:951:29: error: too many arguments to function call, expected 0, have 1
[task 2024-05-17T09:47:18.459Z] 09:47:18     INFO -    951 |     Unused << ReadFromCache(true);
[task 2024-05-17T09:47:18.459Z] 09:47:18     INFO -        |               ~~~~~~~~~~~~~ ^~~~
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.h:404:26: note: 'ReadFromCache' declared here
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -    404 |   [[nodiscard]] nsresult ReadFromCache(void);
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -        |                          ^
[task 2024-05-17T09:47:18.460Z] 09:47:18     INFO -  In file included from Unified_cpp_protocol_http4.cpp:56:
[task 2024-05-17T09:47:18.461Z] 09:47:18    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:983:26: error: too many arguments to function call, expected 0, have 1
[task 2024-05-17T09:47:18.461Z] 09:47:18     INFO -    983 |       rv = ReadFromCache(true);
[task 2024-05-17T09:47:18.461Z] 09:47:18     INFO -        |            ~~~~~~~~~~~~~ ^~~~
[task 2024-05-17T09:47:18.461Z] 09:47:18     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.h:404:26: note: 'ReadFromCache' declared here
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -    404 |   [[nodiscard]] nsresult ReadFromCache(void);
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -        |                          ^
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -  In file included from Unified_cpp_protocol_http4.cpp:56:
[task 2024-05-17T09:47:18.462Z] 09:47:18    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:3597:39: error: too many arguments to function call, expected 0, have 1
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -   3597 |     nsresult rv = self->ReadFromCache(false);
[task 2024-05-17T09:47:18.462Z] 09:47:18     INFO -        |                   ~~~~~~~~~~~~~~~~~~~ ^~~~~

Fixed the issue and rebased the change, thank you!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9866ca157a60
Remove deprecated nslCacheEntry methods and their implementations r=valentin,necko-reviewers

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4decf144658a
Backed out changeset 9866ca157a60 for causing several xpcshell failures.

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out changeset 9866ca157a60 (bug 1894995) for causing several xpcshell failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=9866ca157a60aba081cbf8de7ed49fe39fdaa2ae&selectedTaskRun=VhE8RQsbQ6OdjC2G3quDcw.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=459260167&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=459234234&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/4decf144658a

Bug 1559200 has been relanded.
Sean, there's no need to close the bugs after landing, they will be closed only when they reach mozilla-central as it's deemed as stable code after testing.

Comment 8

[Sean Kim [:sekim]]

@cosminS(In reply to Cosmin Sabou [:CosminS] from comment #7)

Backed out changeset 9866ca157a60 (bug 1894995) for causing several xpcshell failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=9866ca157a60aba081cbf8de7ed49fe39fdaa2ae&selectedTaskRun=VhE8RQsbQ6OdjC2G3quDcw.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=459260167&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=459234234&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/4decf144658a

Bug 1559200 has been relanded.
Sean, there's no need to close the bugs after landing, they will be closed only when they reach mozilla-central as it's deemed as stable code after testing.

Oops, thank you for letting me know

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d04ae8305e6
Remove deprecated nslCacheEntry methods and their implementations r=valentin,necko-reviewers,places-reviewers

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9d04ae8305e6