189513 - Make XMLExtras and document.load use syncloader for sync loads

Status: RESOLVED INVALID

(Core :: XML, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

XMLHttpRequest, DOMParser, and document.load (sync load not yet implemented)
should probably be switched to syncloader. Now they have their own syncloading code.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Moving to 1.4b for now, but might not happen until 1.5a.

Comment 2

[Joe Walp]

In light of Jonas' statement in 190313 comment 8, I intend to revise 
XMLHttpRequest to use nsIChannel::Open directly, rather than revise both 
SyncLoadService [1] and XMLHttpRequest.  Heikki or Jonas, can you confirm that 
this is the preferred route to fix critical bug 190313?

Comment 3

[Joe Walp]

ccing Geoff Smith

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sounds good to me.

Comment 5

[Wladimir Palant]

I tried to rewrite nsIXMLHttpRequest::Send() to use nsIChannel::Open() and it
works fine. However, it still blocks the UI as it is run from the UI thread
(there are several warnings in the sources regarding using nsIChannel::Open()
from the UI thread). At least it fixes the CPU load problem (bug 212820).

Comment 6

[Wladimir Palant]

Attachment: Only a simple functionality test

I've attached my changes of nsXMLHttpRequest.cpp. It is only a test of
nsIChannel::Open() in this context, a proper patch should call event handlers
as well.

Comment 7

[Wayne Mery (:wsmwk)]

is this fixed darin's ptach in bug 326273?