1895153 - [Menu Redesign] Implement "Find in page..." menu functionality

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P1)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

This task is to implement the menu handling of "Find in page..." in the menu redesign.

The old menu calls the following:

1. https://searchfox.org/mozilla-central/rev/bf57a034d975b990b549f990563f1bdab3ca559d/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarMenuController.kt#321-323
2. https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt#444

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1895153 - Implement "Find in page..." menu functionality

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1895153 - Part 2: Rename FindInPageIntegration to FindInPageBinding

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3db1258ab82
Implement "Find in page..." menu functionality r=android-reviewers,petru

Comment 5

[Iulian Moraru]

Backed out for causing fenix apk test failures related to Find in page.

• Push with failures

• Failure log

• Backout link

[task 2024-07-19T08:30:01.545Z]   SUCCESS
[task 2024-07-19T08:30:01.545Z] 
[task 2024-07-19T08:30:01.545Z]   TEST: WHEN find in page feature is started THEN record the find in page browser menu telemetry
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #448
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #535
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #544
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #553
[task 2024-07-19T08:30:01.645Z]     D/glean/MetricsPingSched: The 'metrics' ping was last sent on 1436572800000
[task 2024-07-19T08:30:01.645Z]     I/glean/MetricsPingSched: The 'metrics' ping was already sent today, 1721377801579.
[task 2024-07-19T08:30:01.645Z]     D/glean/MetricsPingSched: Scheduling the 'metrics' ping in 70198421ms
[task 2024-07-19T08:30:01.645Z]   TEST-UNEXPECTED-FAIL | org.mozilla.fenix.components.menu.MenuTelemetryMiddlewareTest.WHEN find in page feature is started THEN record the find in page browser menu telemetry | org.junit.ComparisonFailure: expected:<[find_in_page]> but was:<[quit]>
[task 2024-07-19T08:30:01.645Z] 
[task 2024-07-19T08:30:01.645Z]   TEST: WHEN navigating to the save to collection sheet THEN record the share browser menu telemetry
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #448
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #535
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #544
[task 2024-07-19T08:30:01.645Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #553
[task 2024-07-19T08:30:01.745Z]     D/glean/MetricsPingSched: The 'metrics' ping was last sent on 1436572800000
[task 2024-07-19T08:30:01.745Z]     I/glean/MetricsPingSched: The 'metrics' ping was already sent today, 1721377801649.
[task 2024-07-19T08:30:01.745Z]     D/glean/MetricsPingSched: Scheduling the 'metrics' ping in 70198351ms
[task 2024-07-19T08:30:01.745Z]   SUCCESS

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee9700ff62b0
Implement "Find in page..." menu functionality r=android-reviewers,petru

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ee9700ff62b0