1895196 - Add a `anchor` badge in the markup view to element with a valid `anchor-name`

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Comment 1

[Sebastian Zartner [:sebo]]

Maybe there should also be an anchored badge for the elements that are anchored to an element. And clicking that badge would select the anchor element in the Node View.

Sebastian

Comment 2

[Sebastian Zartner [:sebo]]

Also, maybe the anchor badge should be clickable to toggle an Anchor Positioning highlighter (mentioned in bug 1895187).

Sebastian

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Sebastian Zartner [:sebo] from comment #1)

Maybe there should also be an anchored badge for the elements that are anchored to an element. And clicking that badge would select the anchor element in the Node View.

That's something we could do. One slight concerns is that we may be growing the number of badges we show in the markup view, this might not be ideal. Note that we plan to have such links in the rules view (e.g. Bug 1895183). Also maybe we could have a "Anchors" section in the layout panel, like we do for grid/flex containers, where we could show the anchor and the element anchored to it ? We could file another bug for this

Comment 4

[Sebastian Zartner [:sebo]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)

(In reply to Sebastian Zartner [:sebo] from comment #1)

Maybe there should also be an anchored badge for the elements that are anchored to an element. And clicking that badge would select the anchor element in the Node View.

That's something we could do. One slight concerns is that we may be growing the number of badges we show in the markup view, this might not be ideal.

Maybe it's time to introduce some settings for which badges to show.

Note that we plan to have such links in the rules view (e.g. Bug 1895183).

Yes, I saw that one. Though I still thought it would be worth showing them in the Node View.

Also maybe we could have a "Anchors" section in the layout panel, like we do for grid/flex containers, where we could show the anchor and the element anchored to it ? We could file another bug for this

I also thought of that already. I'll file one.

Sebastian

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1895196 - [devtools] Add anchor badge in markup view for node with valid anchor-name. r=#devtools.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0c75044fa77d
https://hg.mozilla.org/integration/autoland/rev/a539399f72b2
[devtools] Add anchor badge in markup view for node with valid anchor-name. r=devtools-reviewers,devtools-backward-compat-reviewers,ochameau.

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a539399f72b2