1895230 - Object metric type should not serialize null values

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Jan-Erik Rediger [:janerik]]

This is handled correctly in glean_parser for Rust, but I failed to backport those to m-c.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1895230 - Object metric: Correctly skip serialization if empty/none r?chutten!

This was already done in glean_parser, but not backported here.
Plus this also adds the default for arrays.
The new test covers those edge cases.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f44b1f72bfa1
Object metric: Correctly skip serialization if empty/none r=chutten

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing python failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: toolkit/components/glean/tests/pytest/test_glean_parser_rust.py::test_all_metric_types TEST-UNEXPECTED-FAIL

Comment 4

[Jan-Erik Rediger [:janerik]]

d'oh! my own mistake of not running at least our tests locally. fixing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a958dab856bd
Object metric: Correctly skip serialization if empty/none r=chutten

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a958dab856bd