1895261 - webidl generates bad operator== for dictionaries that inherit from other dictionaries

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task)

Description

[Byron Campen [:bwc]]

Sometimes no operator== is generated at all:

https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/mozilla/dom/RTCRtpParametersBinding.h#344-383

Sometimes operator== does not take into account the fields in the base class, even when the base class has an operator==:

https://searchfox.org/mozilla-central/source/__GENERATED__/dom/bindings/RTCRtpCapabilitiesBinding.cpp#305-308

which is a subclass of

https://searchfox.org/mozilla-central/source/__GENERATED__/dom/bindings/RTCRtpCapabilitiesBinding.cpp#155-170

https://searchfox.org/mozilla-central/source/__GENERATED__/dom/bindings/RTCRtpSourcesBinding.cpp#279-285

which is a subclass of

https://searchfox.org/mozilla-central/source/__GENERATED__/dom/bindings/RTCRtpSourcesBinding.cpp#170-185

Comment 1

[Andreas Farre [:farre]]

Peter, do you know what's going on here?

Comment 2

[Peter Van der Beken [:peterv]]

We only generate a operator== for dictionaries containing strings or primitive types (see https://searchfox.org/mozilla-central/rev/ee2ad260c25310a9fbf96031de05bbc0e94394cc/dom/bindings/Codegen.py#17694-17697 and https://bugzilla.mozilla.org/show_bug.cgi?id=1249606#c1). Seems like this needs some fixes for inherited dictionaries.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Bug 1895261 - Only generate an equality operator for WebIDL dictionaries when they have a [GenerateEqualityOperator] extended attribute. r?farre!

This also extends the check for supported types to the types of inherited
members, and automatically generates an equality operator in the base classes if
needed. It also deletes the equality operator if a dictionary doesn't need
one but its parent does.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Diff of the generated binding code

Comment 5

[Peter Van der Beken [:peterv]]

Byron, do you actually need these operator==s? The patch removes them, but we can add them back with the new [GenerateEqualityOperator] if needed.

Comment 6

[Byron Campen [:bwc]]

I don't know that we are currently using them anywhere. Having operator== that covers all of the fields would be useful to us, but I can try that out in a separate bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c5b838b6f0c
Only generate an equality operator for WebIDL dictionaries when they have a [GenerateEqualityOperator] extended attribute. r=farre

Comment 8

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/1c5b838b6f0c