Closed Bug 1895398 Opened 10 months ago Closed 9 months ago

Change the about:profiling test assertion so it doesn't fail frequently when a new feature is added

Categories

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

task

Tracking

(firefox127 fixed)

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: canova, Assigned: canova)

Details

Attachments

(1 file)

We have this assertion in the browser_interaction-between-interfaces.js test that fails every time we add a new feature that's enabled by default.

But if you look at the comment above, it doesn't really test the features, it only tests the threads filter. And specifically it's testing a special path that is executed where the changed thread list has same amount of threads. So it's really not necessary to check all the features. It's better to remove these checks and simplify it since it has caused multiple backouts in the past.

Previously this assertion was checking the whole preset values, including
interval, threads list and the enabled features. But if you look at the info
message above, it actually only intends to test a specific edge case of a
threads filter. So it's not really necessary to check the interval and the
features since that's not really important for this assertion.

I initially wanted to change this assertion because it caused multiple backouts
in the past when we changed the default values of some features. I think it's
better to not check the features here at all to make sure that we won't have
any more backouts in the future.

Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
Summary: Change the about:profiling xpcshell test assertion so it doesn't fail frequently when a new feature is added → Change the about:profiling test assertion so it doesn't fail frequently when a new feature is added
Attachment #9400362 - Attachment description: Bug 1895398 - Change the about:profiling xpcshell test assertion to only check the area it intends to check r?#profiler → Bug 1895398 - Change the about:profiling test assertion to only check the area it intends to check r?#profiler
Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/16c706919fcf Change the about:profiling test assertion to only check the area it intends to check r=profiler-reviewers,florian
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: