Closed Bug 1895419 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 46127 - Revert "Update focus-navigation WPT forward to use test_driver.Actions"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox128 fixed)

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46127 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46127
Details from upstream follow.

Yuki Shiino <yukishiino@chromium.org> wrote:

Revert "Update focus-navigation WPT forward to use test_driver.Actions"

This reverts commit 5ca29ac8df39fb902b44a9f4e1d3118feea544cf.

Reason for revert: Suspicious about causing WPTs failing or flakily failing.
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac11%20Tests/27459/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/19475/overview

Original change's description:

Update focus-navigation WPT forward to use test_driver.Actions

Previous patch changed navigateFocusForward() in focus-utils.js
to send keyboard event on the document.documentElement.
This change was not interoperable [1]. We update to send the keyboard
event using test_driver.Actions() and without specifying an element
to send keys to.

[1] https://github.com/web-platform-tests/wpt/pull/45772#discussion_r1591235292

Change-Id: I3b2a4a38ea4edb4d05d8c4a34505f0f8083f6460
Bug: 40542192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5519292
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Di Zhang \<dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1297032}

Bug: 40542192
Change-Id: I147968c0f75c59f92a5b5406ab20ba1f23f01455
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513895
Commit-Queue: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Yuki Shiino \<yukishiino@chromium.org>
Auto-Submit: Yuki Shiino \<yukishiino@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1297215}

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 26 tests and 5 subtests

Status Summary

Firefox

OK : 26
PASS: 3
FAIL: 53

Chrome

OK : 26
PASS: 37
FAIL: 19

Safari

OK : 26
PASS: 36
FAIL: 20

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Pushed by ctuns@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/a39424d39223 [wpt PR 46127] - Revert "Update focus-navigation WPT forward to use test_driver.Actions", a=testonly

https://hg.mozilla.org/mozilla-central/rev/a39424d39223

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.