1895522 - WebExtensionTest#update silently fails

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect)

Description

[William Durand [:willdurand]]

This is what I am getting:

 0:11.99 TEST_START: org.mozilla.geckoview.test.WebExtensionTest#update
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.WebExtensionTest
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: current=1
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: numtests=1
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: stack=org.junit.AssumptionViolatedException: got: <0>, expected: a value greater than <0>
 0:13.65 org.mozilla.geckoview.test     at org.junit.Assume.assumeThat(Assume.java:106)
 0:13.65 org.mozilla.geckoview.test     at org.mozilla.geckoview.test.WebExtensionTest.update(WebExtensionTest.kt:2902)
 0:13.65 org.mozilla.geckoview.test     at java.lang.reflect.Method.invoke(Native Method)
 0:13.65 org.mozilla.geckoview.test     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
 0:13.65 org.mozilla.geckoview.test     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
 0:13.65 org.mozilla.geckoview.test     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
 0:13.65 org.mozilla.geckoview.test     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
 0:13.65 org.mozilla.geckoview.test     at androidx.test.internal.runner.junit4.statement.RunBefores.evaluate(RunBefores.java:80)
 0:13.65 org.mozilla.geckoview.test     at org.junit.rules.Verifier$1.evaluate(Verifier.java:35)
 0:13.65 org.mozilla.geckoview.test     at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.lambda$evaluate$0(GeckoSessionTestRule.java:1504)
 0:13.65 org.mozilla.geckoview.test     at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.$r8$lambda$eGWMAiU-In-hdc_ISYHPMUhHPKA(Unknown Source:0)
 0:13.65 org.mozilla.geckoview.test     at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2$$ExternalSyntheticLambda1.run(Unknown Source:8)
 0:13.65 org.mozilla.geckoview.test     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
 0:13.65 org.mozilla.geckoview.test     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 0:13.65 org.mozilla.geckoview.test     at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:2296)
 0:13.65 org.mozilla.geckoview.test     at android.os.Handler.handleCallback(Handler.java:938)
 0:13.65 org.mozilla.geckoview.test     at android.os.Handler.dispatchMessage(Handler.java:99)
 0:13.65 org.mozilla.geckoview.test     at android.os.Looper.loopOnce(Looper.java:201)
 0:13.65 org.mozilla.geckoview.test     at android.os.Looper.loop(Looper.java:288)
 0:13.65 org.mozilla.geckoview.test     at android.app.ActivityThread.main(ActivityThread.java:7870)
 0:13.65 org.mozilla.geckoview.test     at java.lang.reflect.Method.invoke(Native Method)
 0:13.65 org.mozilla.geckoview.test     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
 0:13.65 org.mozilla.geckoview.test     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
 0:13.65 org.mozilla.geckoview.test
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: stream=
 0:13.65 org.mozilla.geckoview.test org.mozilla.geckoview.test.WebExtensionTest:
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS: test=update
 0:13.65 org.mozilla.geckoview.test INSTRUMENTATION_STATUS_CODE: -4
 0:13.65 TEST_END: FAIL
 0:13.68 org.mozilla.geckoview.test INSTRUMENTATION_RESULT: stream=
 0:13.68 org.mozilla.geckoview.test
 0:13.68 org.mozilla.geckoview.test Time: 1.665
 0:13.68 org.mozilla.geckoview.test
 0:13.68 org.mozilla.geckoview.test OK (1 test)
 0:13.68 org.mozilla.geckoview.test
 0:13.68 org.mozilla.geckoview.test
 0:13.68 org.mozilla.geckoview.test INSTRUMENTATION_CODE: -1
 0:14.50 INFO Passed: 0
 0:14.50 INFO Failed: 0
 0:14.50 INFO Todo: 1
 0:14.50 SUITE_END

suite 1
~~~~~~~
Ran 1 checks (1 tests)
Expected results: 1
Unexpected results: 0
OK
 0:14.61 INFO Stopping web server
 0:14.62 INFO Server shut down.
 0:14.62 INFO Web server killed.
 0:14.62 INFO Stopping web socket server
 0:14.62 INFO Stopping ssltunnel

As we can see the test fails because of a failed assertion, yet the summary indicates no issue. I am not sure why... maybe the fact that we're using assumeThat()?

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1895522 - Fix WebExtensionTest#update test. r?amejiamarmol!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/508280be0610
Fix WebExtensionTest#update test. r=amejiamarmol,geckoview-reviewers

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/508280be0610