Closed Bug 189579 Opened 22 years ago Closed 22 years ago

make-jars.pl fails with long overrides command

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: colin, Assigned: netscape)

Details

Attachments

(1 file)

Fix long overrides
1.36 KB, patch
netscape
: review+
Details | Diff | Splinter Review 
make-jars.pl has a day-1 bug. There are two places where it handles "command
line too long" by breaking the command up into multiple shorter commands, once
for args and a second time for overrides. Only someone was a little too
heavy-handed on the old cut and paste, and the code which is handling the long
overrides command line ends up using the args data. 

Guess building Phoenix is the first time we've run into overrides being too long.

I have a patch coming up next.

    
  

        Attachment #111911 -
        Flags: review?(cls)

    
    

    
  
Comment on attachment 111911 [details] [diff] [review]
Fix long overrides

r=cls

        Attachment #111911 -
        Flags: review?(cls) → review+

    
    

    
  
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: