1896089 - geckoview-junit doesn't run on Android emulator of Windows

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Makoto Kato [:m_kato]]

adb.py uses tempfile.NamedTemporaryFile to manage stdout.

But, since NamedTemporaryFile is incompatible with Windows due to https://developercommunity.visualstudio.com/t/Support-FILE_SHARE_DELETE-for-_open-and/880630, when opening temporary file without delete=True, it throws an error on Windows.

As workaround, Python 3.12 adds a new option as delete_on_close to delete on closing file. We should use it if possible on Python 3.12+.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1896089 - Use O_TEMPORARY flag to open adb log file. r=jmaher

adb.py uses tempfile.NamedTemporaryFile to manage stdout.

When using it on Windows, opening this file causes PermissionError [*1].

So we have to add the temporary flags on Windows when reading this file.

*1 https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/366f2aa11b3d
Use O_TEMPORARY flag to open adb log file. r=jmaher

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/366f2aa11b3d