Closed Bug 1896227 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 46209 - WebNN: Allow 0-D (scalar) reductions

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 46209 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46209
Details from upstream follow.

Joshua Bell <jsbell@chromium.org> wrote:

WebNN: Allow 0-D (scalar) reductions

crrev.com/c/5496321 added a restriction on the reduction ops
(including argMin/argMax) that the rank of the input tensor must be
greater than zero.

In https://github.com/webmachinelearning/webnn/issues/681, @fdwr
points out that 0-D (scalar) reductions are fine, it's just a no-op.
Per that discussion, this removes a restriction. There are already
WPT cases for argMin/argMax (although they fail for other reasons);
cases are added for the plethora of reduction ops (which also fail
for other reasons).

Change-Id: Ib10a9b0bb3062f9d2b6001d9a4963b14e751d14f
Reviewed-on: https://chromium-review.googlesource.com/5529350
WPT-Export-Revision: f70b949fab6883d78a7dad985374cc4212e4c86c

Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 172 tests and 3 subtests ## Status Summary ### Firefox `OK` : 172 `PASS` : 209 `FAIL` : 879 ### Chrome `OK` : 168 `PASS` : 1569 `FAIL` : 3289 `ERROR` : 4 `NOTRUN`: 18 ### Safari `OK` : 172 `PASS` : 209 `FAIL` : 879 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78fba7eae6250f1d5eca6c263b94facce4b77d02) [GitHub PR Head](https://wpt.fyi/results/?sha=98a2e694335df790591d47515491c1194034c187&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=98a2e694335df790591d47515491c1194034c187&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0431ab437dc9 [wpt PR 46209] - WebNN: Allow 0-D (scalar) reductions, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: