1896344 - Add `CSPViolationData` to reflect the spec more clearly

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Currently, the data a violation (https://w3c.github.io/webappsec-csp/#violation) contains is spread over multiple variables, mixed with other data and passed to CSPReportSenderRunnable (https://searchfox.org/mozilla-central/rev/ee2ad260c25310a9fbf96031de05bbc0e94394cc/dom/security/nsCSPContext.cpp#1378).

This is confusing, when creating a new violation.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1896344: part 1) Add `CSPViolationData` struct with `mViolatedPolicyIndex`. r=tschuster

Closer to the spec.

Other members will be added in separate patches. Initializing
CSPViolationData will be propagated up to
nsCSPContext::AsyncReportViolation in other patches too.

The struct is suffixed with Data, because of
https://searchfox.org/mozilla-central/rev/729361e481cf63c8d2b5617a6ff589f53e302520/dom/workers/remoteworkers/RemoteWorkerTypes.ipdlh#118.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1896344: part 2) Add `mResource` to `CSPViolationData`. r=tschuster

More members will be added in separate patches.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9de9a0cafcf3
part 1) Add `CSPViolationData` struct with `mViolatedPolicyIndex`. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/76f8cba96569
part 2) Add `mResource` to `CSPViolationData`. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/630c85c0c7e4
apply code formatting via Lando

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1896344: part 3) Add line- and column-numbers to `CSPViolationData`. r=tschuster

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9de9a0cafcf3
https://hg.mozilla.org/mozilla-central/rev/76f8cba96569
https://hg.mozilla.org/mozilla-central/rev/630c85c0c7e4

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1896344: part 4) Move script-sample to `CSPViolationData`. r=tschuster

Depends on D213053

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1896344: part 5) Move source file to `CSPViolationData`. r=tschuster

Depends on D213403

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d0a99740b88
part 3) Add line- and column-numbers to `CSPViolationData`. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/6863b8134c9f
part 4) Move script-sample to `CSPViolationData`. r=tschuster

Comment 9

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1896344: part 6) Move the element which triggered the violation to `CSPViolationData`. r=tschuster

Depends on D213543

Comment 10

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1896344: part 7) Move effective directive to `CSPViolationData`. r=tschuster

Depends on D213548

Comment 11

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/5d0a99740b88
https://hg.mozilla.org/mozilla-central/rev/6863b8134c9f

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b829c66ee57f
part 5) Move source file to `CSPViolationData`. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/0b77c4e26e2f
part 6) Move the element which triggered the violation to `CSPViolationData`. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/cbcfc1175b1d
part 7) Move effective directive to `CSPViolationData`. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/89cc9109f716
apply code formatting via Lando

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b829c66ee57f
https://hg.mozilla.org/mozilla-central/rev/0b77c4e26e2f
https://hg.mozilla.org/mozilla-central/rev/cbcfc1175b1d
https://hg.mozilla.org/mozilla-central/rev/89cc9109f716