1896414 - Move MOZ_ASAN checks from old.configure to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1896414 - Move MOZ_ASAN checks from old.configure to moz.configure r=glandium!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2740e0cb1ac8
Move MOZ_ASAN checks from old.configure to moz.configure r=glandium
https://hg.mozilla.org/integration/autoland/rev/b1e69d42bb91
1900540: apply code formatting via Lando

Comment 3

[Iulian Moraru]

Backed out 3 changesets (bug 1900540, bug 1896414) for causing Gtest failures.

• Push with failures

• Failure log

• Backout link

[task 2024-06-11T18:23:04.366Z] 18:23:04     INFO -  TEST-START | BuildIDReader.ReadCorrectBuildIdFromLib
[task 2024-06-11T18:23:04.367Z] 18:23:04     INFO -  [ERROR buildid_reader::reader] BuildIdReader::read_string_build_id failed to read raw build id with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.368Z] 18:23:04     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to read string buiild id from note ".note.moz.toolkit-build-id" with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.369Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadCorrectBuildIdFromLib | Value of: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
[task 2024-06-11T18:23:04.369Z] 18:23:04     INFO -    Actual: false
[task 2024-06-11T18:23:04.370Z] 18:23:04     INFO -  Expected: true
[task 2024-06-11T18:23:04.371Z] 18:23:04     INFO -  Error reading from libxul_correct_buildid.so: 80040111
[task 2024-06-11T18:23:04.372Z] 18:23:04     INFO -   @ /builds/worker/checkouts/gecko/toolkit/library/gtest/TestBuildIDReader.cpp:83
[task 2024-06-11T18:23:04.373Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadCorrectBuildIdFromLib | test completed (time: 0ms)
[task 2024-06-11T18:23:04.374Z] 18:23:04     INFO -  TEST-START | BuildIDReader.ReadIncorrectBuildIdFromLib
[task 2024-06-11T18:23:04.375Z] 18:23:04     INFO -  [ERROR buildid_reader::reader] BuildIdReader::read_string_build_id failed to read raw build id with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.376Z] 18:23:04     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to read string buiild id from note ".note.moz.toolkit-build-id" with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.377Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadIncorrectBuildIdFromLib | Value of: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
[task 2024-06-11T18:23:04.378Z] 18:23:04     INFO -    Actual: false
[task 2024-06-11T18:23:04.379Z] 18:23:04     INFO -  Expected: true
[task 2024-06-11T18:23:04.380Z] 18:23:04     INFO -  Error reading from libxul_correct_buildid.so: 80040111
[task 2024-06-11T18:23:04.381Z] 18:23:04     INFO -   @ /builds/worker/checkouts/gecko/toolkit/library/gtest/TestBuildIDReader.cpp:100
[task 2024-06-11T18:23:04.382Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadIncorrectBuildIdFromLib | test completed (time: 0ms)
[task 2024-06-11T18:23:04.383Z] 18:23:04     INFO -  TEST-START | BuildIDReader.ReadMissingBuildIdFromLib
[task 2024-06-11T18:23:04.383Z] 18:23:04     INFO -  [ERROR buildid_reader::reader] BuildIdReader::read_string_build_id failed to read raw build id with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.383Z] 18:23:04     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to read string buiild id from note ".note.moz.toolkit-build-id" with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.383Z] 18:23:04     INFO -  TEST-PASS | BuildIDReader.ReadMissingBuildIdFromLib | test completed (time: 0ms)
[task 2024-06-11T18:23:04.383Z] 18:23:04     INFO -  TEST-START | BuildIDReader.ReadFromMissingLib
[task 2024-06-11T18:23:04.384Z] 18:23:04     INFO -  [ERROR buildid_reader::reader] BuildIdReader::new failed to open "/builds/worker/workspace/build/application/firefox/gtest/inexistent-lib.so" with error No such file or directory (os error 2)
[task 2024-06-11T18:23:04.384Z] 18:23:04     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to build BuildIdReader for "/builds/worker/workspace/build/application/firefox/gtest/inexistent-lib.so" with error NS_ERROR_ILLEGAL_VALUE
[task 2024-06-11T18:23:04.384Z] 18:23:04     INFO -  TEST-PASS | BuildIDReader.ReadFromMissingLib | test completed (time: 0ms)
[task 2024-06-11T18:23:04.384Z] 18:23:04     INFO -  TEST-START | BuildIDReader.ReadFromRealLib
[task 2024-06-11T18:23:04.384Z] 18:23:04     INFO -  [ERROR buildid_reader::reader] BuildIdReader::read_string_build_id failed to read raw build id with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.384Z] 18:23:04     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to read string buiild id from note ".note.moz.toolkit-build-id" with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.385Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromRealLib | Value of: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
[task 2024-06-11T18:23:04.385Z] 18:23:04     INFO -    Actual: false
[task 2024-06-11T18:23:04.385Z] 18:23:04     INFO -  Expected: true
[task 2024-06-11T18:23:04.385Z] 18:23:04     INFO -  Error reading from libxul.so: 80040111
[task 2024-06-11T18:23:04.385Z] 18:23:04     INFO -   @ /builds/worker/checkouts/gecko/toolkit/library/gtest/TestBuildIDReader.cpp:153
[task 2024-06-11T18:23:04.385Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromRealLib | test completed (time: 0ms)
[task 2024-06-11T18:23:04.386Z] 18:23:04     INFO -  TEST-START | BuildIDReader.ReadFromNSAppRunner
[task 2024-06-11T18:23:04.386Z] 18:23:04     INFO -  [ERROR buildid_reader::reader] BuildIdReader::read_string_build_id failed to read raw build id with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.386Z] 18:23:04     INFO -  [ERROR buildid_reader] read_toolkit_buildid_from_file failed to read string buiild id from note ".note.moz.toolkit-build-id" with error NS_ERROR_NOT_AVAILABLE
[task 2024-06-11T18:23:04.386Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromNSAppRunner | Value of: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
[task 2024-06-11T18:23:04.386Z] 18:23:04     INFO -    Actual: false
[task 2024-06-11T18:23:04.386Z] 18:23:04     INFO -  Expected: true
[task 2024-06-11T18:23:04.387Z] 18:23:04     INFO -  Error reading from libxul.so: 80040111
[task 2024-06-11T18:23:04.387Z] 18:23:04     INFO -   @ /builds/worker/checkouts/gecko/toolkit/library/gtest/TestBuildIDReader.cpp:170
[task 2024-06-11T18:23:04.387Z] 18:23:04  WARNING -  TEST-UNEXPECTED-FAIL | BuildIDReader.ReadFromNSAppRunner | test completed (time: 0ms)
[task 2024-06-11T18:23:04.387Z] 18:23:04     INFO -  TEST-START | VolatileBufferTest.HeapVolatileBuffersWork

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65a675f06555
Move MOZ_ASAN checks from old.configure to moz.configure r=glandium,geckoview-reviewers,m_kato

Comment 5

[Mathew Hodson]

Looks like there was a typo in this block here:

# Look for the ASan runtime binary
if c_compiler.type == "clang-cl":
    cpu = {"x86": "i386"}.get(target.cpu, target.cpu)
    clang_rt_asan_lib = f"clang_rt.asan_dynamic-{target.cpu}.dll"

The cpu variable isn't used. Looks like it should have been f"clang_rt.asan_dynamic-{cpu}.dll". Otherwise, it will look for clang_rt.asan_dynamic-x86.dll instead of clang_rt.asan_dynamic-i386.dll.

Comment 6

[[:sergesanspaille]]

Indeed. I'll submit a patch.

Comment 7

[[:sergesanspaille]]

Attachment: Bug 1896414 - Fix typo in moz.configure ASAN check r=mhodson

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/65a675f06555

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7510492f2e0
Fix typo in moz.configure ASAN check r=mhodson

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f7510492f2e0