1896505 - Add use-counter telemetry for subclassing types

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

See https://github.com/tc39/proposal-rm-builtin-subclassing for the proposal; this bug tracks adding use counter telemetry to enable tracking these subclassing types to determine their dynamic prevelance so that we can decide if this proposal has a chance of progressing.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Document IsArraySpecies r?jandem

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Define UseCounters with a macro list to ease future code generation r?jandem

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Add a testing function to be able to read out shell use counter data r?jandem

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Add initial reporting machinery for subclassing. r?jandem

This patch will report the Type II Array subclassing.

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track Promise Type II subclassing r?jandem,yulia

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track TypedArray Type II Subclassing r?jandem,yulia

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track Type III Subclassing in Array r?yulia,jandem

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track Type III Subclassing in Promise r?jandem,yulia

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track Type III subclassing in TypedArrays r?jandem,yulia

Comment 10

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track Type III subclassing in ArrayBuffer and SharedArrayBuffer r?jandem,yulia

Comment 11

[Matthew Gaudet (he/him) [:mgaudet]]

Performance Impact seems to be minimal; measurements with local microbenchmarks don't show much slow down, and here is a try push with no confident changes.

Comment 12

[Matthew Gaudet (he/him) [:mgaudet]]

Note: I have no patches written for the RegExp Type IV subclassing yet.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/430d4667cdfe
Document IsArraySpecies r=jandem
https://hg.mozilla.org/integration/autoland/rev/3de07420b464
Define UseCounters with a macro list to ease future code generation r=jandem
https://hg.mozilla.org/integration/autoland/rev/1b6d47b2fddc
Add a testing function to be able to read out shell use counter data r=jandem
https://hg.mozilla.org/integration/autoland/rev/0705dd0789c1
Add initial reporting machinery for subclassing. r=jandem
https://hg.mozilla.org/integration/autoland/rev/dd8c51e513f4
Track Promise Type II subclassing r=jandem
https://hg.mozilla.org/integration/autoland/rev/c83e6896006d
Track TypedArray Type II Subclassing r=jandem
https://hg.mozilla.org/integration/autoland/rev/8928f4e3e470
Track Type III Subclassing in Array r=jandem
https://hg.mozilla.org/integration/autoland/rev/51507968e1ae
Track Type III Subclassing in Promise r=jandem
https://hg.mozilla.org/integration/autoland/rev/9d3c1db7d808
Track Type III subclassing in TypedArrays r=jandem
https://hg.mozilla.org/integration/autoland/rev/2887f4f28f09
Track Type III subclassing in ArrayBuffer and SharedArrayBuffer r=jandem
https://hg.mozilla.org/integration/autoland/rev/574facb67f7f
1896595: apply code formatting via Lando

Comment 14

[Cristian Tuns]

Backed out for a typo in the bug nr.
Backout link: https://hg.mozilla.org/integration/autoland/rev/177557435af5ae8afcc5cc84bddf20b23f10839e

Comment 15

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track Type III Subclassing in RegExp r?jandem,yulia

The challenge of getting this right is truly comical.

Comment 16

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1896505 - Track Type IV Subclassing in RegExp r?jandem,yulia

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72cb6cb4751b
Document IsArraySpecies r=jandem
https://hg.mozilla.org/integration/autoland/rev/e87f8db5d7dd
Define UseCounters with a macro list to ease future code generation r=jandem
https://hg.mozilla.org/integration/autoland/rev/c53f704e9298
Add a testing function to be able to read out shell use counter data r=jandem
https://hg.mozilla.org/integration/autoland/rev/fa744dc84f2c
Add initial reporting machinery for subclassing. r=jandem
https://hg.mozilla.org/integration/autoland/rev/cf7f56a0bab0
Track Promise Type II subclassing r=jandem
https://hg.mozilla.org/integration/autoland/rev/0619a4b617fe
Track TypedArray Type II Subclassing r=jandem
https://hg.mozilla.org/integration/autoland/rev/8d5a38566676
Track Type III Subclassing in Array r=jandem
https://hg.mozilla.org/integration/autoland/rev/bf9c11e5d5a4
Track Type III Subclassing in Promise r=jandem
https://hg.mozilla.org/integration/autoland/rev/999de4ddd8c9
Track Type III subclassing in TypedArrays r=jandem
https://hg.mozilla.org/integration/autoland/rev/0d5dd25610fc
Track Type III subclassing in ArrayBuffer and SharedArrayBuffer r=jandem
https://hg.mozilla.org/integration/autoland/rev/4b0ae75cb06d
Track Type III Subclassing in RegExp r=jandem
https://hg.mozilla.org/integration/autoland/rev/490483041313
Track Type IV Subclassing in RegExp r=jandem
https://hg.mozilla.org/integration/autoland/rev/c71ee627271d
apply code formatting via Lando

Comment 18

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/72cb6cb4751b
https://hg.mozilla.org/mozilla-central/rev/e87f8db5d7dd
https://hg.mozilla.org/mozilla-central/rev/c53f704e9298
https://hg.mozilla.org/mozilla-central/rev/fa744dc84f2c
https://hg.mozilla.org/mozilla-central/rev/cf7f56a0bab0
https://hg.mozilla.org/mozilla-central/rev/0619a4b617fe
https://hg.mozilla.org/mozilla-central/rev/8d5a38566676
https://hg.mozilla.org/mozilla-central/rev/bf9c11e5d5a4
https://hg.mozilla.org/mozilla-central/rev/999de4ddd8c9
https://hg.mozilla.org/mozilla-central/rev/0d5dd25610fc
https://hg.mozilla.org/mozilla-central/rev/4b0ae75cb06d
https://hg.mozilla.org/mozilla-central/rev/490483041313
https://hg.mozilla.org/mozilla-central/rev/c71ee627271d