1896536 - Update harfbuzz to new version 8.5.0 from 2024-05-13 23:46:17

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Update Bot]

This update covers 76 commits. Here are the overall diff statistics, and then the commit information.

---

gfx/harfbuzz/NEWS | 15 +
gfx/harfbuzz/configure.ac | 2 +-
gfx/harfbuzz/moz.yaml | 4 +-
gfx/harfbuzz/src/Makefile.am | 5 +
gfx/harfbuzz/src/OT/Color/COLR/COLR.hh | 312 ++++++++++++++++++++--
gfx/harfbuzz/src/OT/Color/COLR/colrv1-closure.hh | 50 ++-
gfx/harfbuzz/src/OT/Layout/GDEF/GDEF.hh | 41 ---
gfx/harfbuzz/src/OT/Layout/GSUB/Ligature.hh | 15 +-
gfx/harfbuzz/src/check-c-linkage-decls.py | 1 +
gfx/harfbuzz/src/fix_get_types.py | 2 +-
gfx/harfbuzz/src/gen-def.py | 2 -
gfx/harfbuzz/src/gen-tag-table.py | 18 +-
gfx/harfbuzz/src/hb-aat-layout-common.hh | 203 ++++++++++++--
gfx/harfbuzz/src/hb-aat-layout-kerx-table.hh | 183 ++++++++++++-
gfx/harfbuzz/src/hb-aat-layout-morx-table.hh | 262 ++++++++++++++++--
gfx/harfbuzz/src/hb-aat-layout.cc | 53 ++-
gfx/harfbuzz/src/hb-algs.hh | 4 +
gfx/harfbuzz/src/hb-cff2-interp-cs.hh | 8 +-
gfx/harfbuzz/src/hb-cplusplus.hh | 3 -
gfx/harfbuzz/src/hb-ot-face-table-list.hh | 8 +-
gfx/harfbuzz/src/hb-ot-face.cc | 2 +
gfx/harfbuzz/src/hb-ot-hmtx-table.hh | 3 +-
gfx/harfbuzz/src/hb-ot-kern-table.hh | 71 ++++-
gfx/harfbuzz/src/hb-ot-layout-base-table.hh | 75 ++++-
gfx/harfbuzz/src/hb-ot-layout-common.hh | 14 +-
gfx/harfbuzz/src/hb-ot-layout-gsubgpos.hh | 83 +++++-
gfx/harfbuzz/src/hb-ot-layout.cc | 8 +-
gfx/harfbuzz/src/hb-ot-os2-table.hh | 2 +-
gfx/harfbuzz/src/hb-ot-post-table.hh | 2 +-
gfx/harfbuzz/src/hb-ot-stat-table.hh | 3 +-
gfx/harfbuzz/src/hb-ot-tag-table.hh | 45 +---
gfx/harfbuzz/src/hb-ot-var-avar-table.hh | 8 +-
gfx/harfbuzz/src/hb-ot-var-common.hh | 94 +++---
gfx/harfbuzz/src/hb-ot-var-fvar-table.hh | 7 +-
gfx/harfbuzz/src/hb-ot-var-gvar-table.hh | 5 +-
gfx/harfbuzz/src/hb-repacker.hh | 18 +-
gfx/harfbuzz/src/hb-set-digest.hh | 20 +-
gfx/harfbuzz/src/hb-set.hh | 2 +-
gfx/harfbuzz/src/hb-subset-cff-common.hh | 57 +++-
gfx/harfbuzz/src/hb-subset-cff2.cc | 3 +
gfx/harfbuzz/src/hb-subset-input.cc | 15 +-
gfx/harfbuzz/src/hb-subset-instancer-iup.cc | 68 ++--
gfx/harfbuzz/src/hb-subset-instancer-iup.hh | 2 +-
gfx/harfbuzz/src/hb-subset-instancer-solver.cc | 94 +++---
gfx/harfbuzz/src/hb-subset-instancer-solver.hh | 32 +-
gfx/harfbuzz/src/hb-subset-plan-member-list.hh | 8 +-
gfx/harfbuzz/src/hb-subset-plan.cc | 183 +++++++++---
gfx/harfbuzz/src/hb-subset.h | 11 +-
gfx/harfbuzz/src/hb-version.h | 4 +-
gfx/harfbuzz/src/hb-wasm-api.h | 3 +
gfx/harfbuzz/src/meson.build | 1 +
51 files changed, 1594 insertions(+), 540 deletions(-)

---

30485ee8c3d43c553afb9d78b9924cb71c8d2f19 by Khaled Hosny <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/30485ee8c3d43c553afb9d78b9924cb71c8d2f19
Authored: 2024-05-13 23:45:50 +0300
Committed: 2024-05-13 23:46:17 +0300

Typo

---

9ea29789d7e85900853a0bd54f968c33ecd52b93 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/9ea29789d7e85900853a0bd54f968c33ecd52b93
Authored: 2024-05-13 14:43:47 -0600
Committed: 2024-05-13 14:45:41 -0600

[aat] Minor

---

71b1ba7aa678771b34ea4a0c062aa8622bc3ffaf by Khaled Hosny <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/71b1ba7aa678771b34ea4a0c062aa8622bc3ffaf
Authored: 2024-05-13 23:07:51 +0300
Committed: 2024-05-13 23:42:50 +0300

8.5.0

---

0660a4d408736e663c1c7274fff400be546f998f by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/0660a4d408736e663c1c7274fff400be546f998f
Authored: 2024-05-13 19:28:57 +0000
Committed: 2024-05-13 13:39:20 -0700

[subset] fix fuzzer found heap use after free in BASE subsetting.

---

3f38ffd633b143e13e1899073d5d33fd9ad3a9e1 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/3f38ffd633b143e13e1899073d5d33fd9ad3a9e1
Authored: 2024-05-13 18:50:43 +0000
Committed: 2024-05-13 13:18:27 -0700

[subset] Fix remaining double conversion warnings.

---

6253b3a905ff516aabac62516c28a86eececb7b9 by Steve Lhomme <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/6253b3a905ff516aabac62516c28a86eececb7b9
Authored: 2024-05-13 11:01:58 +0200
Committed: 2024-05-13 20:42:13 +0300

[meson] build ragel as a native tool

---

3609ebb0d134212f0113906f5d100cdb94126c96 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/3609ebb0d134212f0113906f5d100cdb94126c96
Authored: 2024-05-13 11:05:04 -0600
Committed: 2024-05-13 11:06:57 -0600

[htmx] Return non-variable advance if no glyf table available

---

3d3c6db4b2de657c535b2d6c04446a99a9e99876 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/3d3c6db4b2de657c535b2d6c04446a99a9e99876
Authored: 2024-05-13 11:00:21 -0600
Committed: 2024-05-13 11:00:21 -0600

[kern] Allow format 1 / 3 in OT-style kern table

---

fb6074259483fe0132e3ed4dc5e8bc5efb3ecfa9 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/fb6074259483fe0132e3ed4dc5e8bc5efb3ecfa9
Authored: 2024-05-13 10:27:02 +0000
Committed: 2024-05-13 07:33:41 -0700

Bump github/codeql-action from 3.25.3 to 3.25.4

---

364ae509b5901c9d4019d9794ed570bc82fc6248 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/364ae509b5901c9d4019d9794ed570bc82fc6248
Authored: 2024-05-13 10:27:05 +0000
Committed: 2024-05-13 07:33:35 -0700

Bump ossf/scorecard-action from 2.3.1 to 2.3.3

---

44d8489fddd98d1f092849836cec4f95678d88cb by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/44d8489fddd98d1f092849836cec4f95678d88cb
Authored: 2024-05-13 10:27:10 +0000
Committed: 2024-05-13 07:33:27 -0700

Bump actions/checkout from 4.1.4 to 4.1.5

---

e2ab6c7bc87cb3f52329278bd8419d58b4f85c4d by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/e2ab6c7bc87cb3f52329278bd8419d58b4f85c4d
Authored: 2024-05-12 15:25:13 -0600
Committed: 2024-05-13 00:22:04 -0600

[kern/kerx] Add accelerator and set-digest filtering

---

5f32c60d05f4664ad28ae450fdb25326b688ad7d by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/5f32c60d05f4664ad28ae450fdb25326b688ad7d
Authored: 2024-05-12 15:16:25 -0600
Committed: 2024-05-12 15:16:25 -0600

[kerx] Remove set-digests since accelerator is not shared

---

ebbec7713bbdb405844e46015db2bef178e9e069 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/ebbec7713bbdb405844e46015db2bef178e9e069
Authored: 2024-05-12 15:10:21 -0600
Committed: 2024-05-12 15:11:00 -0600

[kern] Use the sanitized version from face

---

23e4a3cf2612ef240b8d882c7031f5f6a8d7c91f by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/23e4a3cf2612ef240b8d882c7031f5f6a8d7c91f
Authored: 2024-05-12 10:49:46 -0600
Committed: 2024-05-12 15:11:00 -0600

[aat/morx] Add an accelerator

---

0828ccc5dc8db56dc64f248a0e6657a322334a40 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/0828ccc5dc8db56dc64f248a0e6657a322334a40
Authored: 2024-05-12 10:06:06 -0600
Committed: 2024-05-12 10:06:06 -0600

[aat] Move buffer out of StateTableDriver

---

bba0c0e27cf22244d6ffcd9dffc8e9ad1f4c1bc6 by David Corbett <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/bba0c0e27cf22244d6ffcd9dffc8e9ad1f4c1bc6
Authored: 2024-05-11 23:15:35 -0400
Committed: 2024-05-12 09:04:02 -0700

Add test-cff.cc

---

0db136b1b09232083d99e4315dd4432ed0195d2c by David Corbett <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/0db136b1b09232083d99e4315dd4432ed0195d2c
Authored: 2024-05-09 11:49:48 -0400
Committed: 2024-05-12 09:04:02 -0700

[subset-cff] Shorten output of encode_num_tp

---

5a405b310e617c1ee87491401c98f70dff2e2a51 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/5a405b310e617c1ee87491401c98f70dff2e2a51
Authored: 2024-05-11 10:03:47 -0600
Committed: 2024-05-11 10:28:02 -0600

[aat] First sketch at using hb_set_digest_t

---

51582558075557db274de8893bc43b1f0fd37893 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/51582558075557db274de8893bc43b1f0fd37893
Authored: 2024-05-11 09:25:22 -0600
Committed: 2024-05-11 10:02:35 -0600

[set-digest] Add operator []. Also auto-initialize

---

3d75d445e474b9f5bde7ab47514498f30836de50 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/3d75d445e474b9f5bde7ab47514498f30836de50
Authored: 2024-05-11 08:58:58 -0600
Committed: 2024-05-11 08:58:58 -0600

[set] Clarify add_range() params

---

7975c9cabda33f6f02fb7dd3d54dd8e46dc84950 by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/7975c9cabda33f6f02fb7dd3d54dd8e46dc84950
Authored: 2024-05-08 10:11:03 -0700
Committed: 2024-05-09 08:34:14 -0700

[instancer] bug fix for COLRv1, add missing mapping to VarIdx::NO_VARIATION

---

b74a7ecc93e283d059df51ee4f46961a782bcdb8 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/b74a7ecc93e283d059df51ee4f46961a782bcdb8
Authored: 2024-05-07 19:53:01 +0000
Committed: 2024-05-08 10:23:31 -0600

Fix IUP differences accoss platforms.

---

0e1ffd77f90cd81320557d4ebce285b121c7325c by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/0e1ffd77f90cd81320557d4ebce285b121c7325c
Authored: 2024-05-07 13:55:03 -0700
Committed: 2024-05-07 17:07:22 -0600

[instancer] add a warning for CFF partial instancing

---

a3d8a59dc2f365728e6ac7ecaa87413ddcaf1d19 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/a3d8a59dc2f365728e6ac7ecaa87413ddcaf1d19
Authored: 2024-05-07 18:32:56 +0000
Committed: 2024-05-07 12:37:33 -0600

Fix double to float cast warning.

---

6ef69f749dae3c5819cb4eb502c103276d649c27 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/6ef69f749dae3c5819cb4eb502c103276d649c27
Authored: 2024-05-07 10:43:48 -0700
Committed: 2024-05-07 10:43:48 -0700

[cff2] Minor init

---

ca6425704defad269380e9433ec0e9b2afc61d75 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/ca6425704defad269380e9433ec0e9b2afc61d75
Authored: 2024-05-07 10:19:30 -0700
Committed: 2024-05-07 10:19:30 -0700

Rename result_t to rebase_tent_result_t

---

a96f7c878413b1de5061cc6961685edc191f9e2f by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/a96f7c878413b1de5061cc6961685edc191f9e2f
Authored: 2024-05-06 20:41:37 +0000
Committed: 2024-05-06 14:57:35 -0600

Bump jinja2 from 3.1.3 to 3.1.4 in /.ci

---

a5c9c82692f3ec6a7b831ec312966882ebc8c49c by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/a5c9c82692f3ec6a7b831ec312966882ebc8c49c
Authored: 2024-05-06 13:22:49 -0700
Committed: 2024-05-06 13:22:49 -0700

rename expected files from .retain-all-codepoint. to .all.

---

3b3c154bd1da1969199a5d4add1a643ab057a828 by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/3b3c154bd1da1969199a5d4add1a643ab057a828
Authored: 2024-05-06 12:56:23 -0700
Committed: 2024-05-06 12:56:23 -0700

add back missing tests that were disabled when wrapped by experimental

---

6c8985724e257b1525da6698bf7ce054a3dad9a5 by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/6c8985724e257b1525da6698bf7ce054a3dad9a5
Authored: 2024-05-02 10:11:06 -0700
Committed: 2024-05-06 10:42:03 -0700

fix bots

---

f614a7d3095c2ad8fe3551ffee4a44adc2c4b14c by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/f614a7d3095c2ad8fe3551ffee4a44adc2c4b14c
Authored: 2024-05-02 10:05:18 -0700
Committed: 2024-05-06 10:41:07 -0700

[instancer] add/update tests for COLRv1 instancing

---

247039de5afebacf0a84b4c59ae814c9743c23c5 by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/247039de5afebacf0a84b4c59ae814c9743c23c5
Authored: 2024-04-26 13:36:52 -0700
Committed: 2024-05-06 10:41:07 -0700

[instancer] partial instantiating support for COLRv1

---

625a9a963ac4dc885e72fb68ee51cbe07c4fd76b by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/625a9a963ac4dc885e72fb68ee51cbe07c4fd76b
Authored: 2024-05-03 14:52:53 -0700
Committed: 2024-05-03 17:22:16 -0500

[instancer] use correct constant for No VARIATIONS index

---

ebcdadbf546dc7a067bb18f1fa232c4871faf943 by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/ebcdadbf546dc7a067bb18f1fa232c4871faf943
Authored: 2024-05-03 14:24:56 -0700
Committed: 2024-05-03 17:22:16 -0500

[instancer] add tests for instantiating BASE table

---

c5a85a73fa66fee7524f5e39ba5751e25b5b0f49 by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/c5a85a73fa66fee7524f5e39ba5751e25b5b0f49
Authored: 2024-05-03 09:44:14 -0700
Committed: 2024-05-03 17:22:16 -0500

[instancer] support BASE table

---

f145ab2f1ef326746cd625493d4b5af2271bd967 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/f145ab2f1ef326746cd625493d4b5af2271bd967
Authored: 2024-05-03 18:24:33 +0000
Committed: 2024-05-03 18:31:18 +0000

Disable empty_region_vardata test when running on 32bit machines.

---

e81c8c1312f2c9140960520cedeea8264ca7f0ee by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/e81c8c1312f2c9140960520cedeea8264ca7f0ee
Authored: 2024-05-03 18:06:14 +0000
Committed: 2024-05-03 18:06:14 +0000

Change tolerance from float to double.

---

36e82fd5b35b29044d7bc24be3326ed8d0fc6e26 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/36e82fd5b35b29044d7bc24be3326ed8d0fc6e26
Authored: 2024-05-03 17:33:37 +0000
Committed: 2024-05-03 17:33:37 +0000

Use sizeof(repeat_x_deltas[0]) instead of sizeof(int).

---

f03bf49978070c165a4e6c5fc86d7b1fde02f038 by Khaled Hosny <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/f03bf49978070c165a4e6c5fc86d7b1fde02f038
Authored: 2024-05-03 00:35:40 +0300
Committed: 2024-05-03 13:46:31 +0300

[ci] Try to fix finding ICU on macOS runner

---

91f54d4bae20a109382c913340b4c67da781f4e0 by Khaled Hosny <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/91f54d4bae20a109382c913340b4c67da781f4e0
Authored: 2024-05-03 00:15:38 +0300
Committed: 2024-05-03 13:46:31 +0300

[ci] Try to fix pip install on macOS runner

---

0617266273ade741b4ed34648f5f7cb55741ddec by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/0617266273ade741b4ed34648f5f7cb55741ddec
Authored: 2024-05-02 22:05:03 +0000
Committed: 2024-05-02 22:05:03 +0000

Test using double's in IUP optimizatio code.

---

ba1f194a1d62164be439a7f1f8ed9a87da9f7061 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/ba1f194a1d62164be439a7f1f8ed9a87da9f7061
Authored: 2024-05-02 12:18:11 -0600
Committed: 2024-05-02 16:37:51 -0500

[gsubgpos] Reduce stack use in recursion

---

4cf606f6740ffaa618a61d24517eeeb199cf1729 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/4cf606f6740ffaa618a61d24517eeeb199cf1729
Authored: 2024-05-02 20:46:29 +0000
Committed: 2024-05-02 21:22:18 +0000

[instancer] Promote partial instancing api out of experimental.

---

c04d0a295f7ca081f8d086acf329e9be099b791c by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/c04d0a295f7ca081f8d086acf329e9be099b791c
Authored: 2024-04-25 14:57:36 -0700
Committed: 2024-05-02 12:13:11 -0500

[subset] generate colrv1 varsotre inner_maps in the plan

---

690893e3673815c90d2635894e111c5170ec8656 by Qunxin Liu <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/690893e3673815c90d2635894e111c5170ec8656
Authored: 2023-10-02 09:09:53 -0700
Committed: 2024-05-02 12:13:11 -0500

[subset] collect variation indices for COLRv1

---

6ac7a05cdc2f3597bd65c30bd2ab019991761a33 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/6ac7a05cdc2f3597bd65c30bd2ab019991761a33
Authored: 2024-04-29 10:49:34 +0000
Committed: 2024-04-29 09:12:33 -0500

Bump actions/upload-artifact from 4.3.2 to 4.3.3

---

11f37aac8fe7db9eca96fbc0fb8dfcad4bae3b1e by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/11f37aac8fe7db9eca96fbc0fb8dfcad4bae3b1e
Authored: 2024-04-29 10:49:30 +0000
Committed: 2024-04-29 09:12:21 -0500

Bump hendrikmuhs/ccache-action from 1.2.12 to 1.2.13

---

77b9b8c862a51ae80cda1d9abeee2a965d65739b by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/77b9b8c862a51ae80cda1d9abeee2a965d65739b
Authored: 2024-04-29 10:49:25 +0000
Committed: 2024-04-29 09:12:12 -0500

Bump github/codeql-action from 3.25.1 to 3.25.3

---

c7b4f16ae8b516b2d97830d9b2df62e7090d24ec by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/c7b4f16ae8b516b2d97830d9b2df62e7090d24ec
Authored: 2024-04-29 10:49:17 +0000
Committed: 2024-04-29 09:12:02 -0500

Bump actions/checkout from 4.1.3 to 4.1.4

---

aeadd7c1a682d7bdbc9ae5a39dd1f7ba12394679 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/aeadd7c1a682d7bdbc9ae5a39dd1f7ba12394679
Authored: 2024-04-23 19:50:19 +0000
Committed: 2024-04-23 14:13:30 -0600

[subset] Offsets in BaseLangSysRecord are relative to the parent table and not the BaseLangSysRecord.

---

33cae9b4f5cc9905e28c0e704b061f712e8b2b3e by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/33cae9b4f5cc9905e28c0e704b061f712e8b2b3e
Authored: 2024-04-19 21:58:10 +0000
Committed: 2024-04-22 11:16:36 -0600

[repacker] If repacking fails for GSUB/GPOS try re-running with extension promotion and table splitting.

---

adab75fbaa410e622aab5dbdfe3b3340ec5f59e0 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/adab75fbaa410e622aab5dbdfe3b3340ec5f59e0
Authored: 2024-04-22 10:33:25 +0000
Committed: 2024-04-22 10:59:03 -0500

Bump actions/upload-artifact from 4.3.1 to 4.3.2

---

7aab4847db2abfa91ffe9b03b7cb0f1ee8102a17 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/7aab4847db2abfa91ffe9b03b7cb0f1ee8102a17
Authored: 2024-04-22 10:33:33 +0000
Committed: 2024-04-22 10:58:57 -0500

Bump github/codeql-action from 3.24.10 to 3.25.1

---

e2892805a9a0512b5d8c066e3754aefbadcfc070 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/e2892805a9a0512b5d8c066e3754aefbadcfc070
Authored: 2024-04-22 10:33:38 +0000
Committed: 2024-04-22 10:58:51 -0500

Bump actions/checkout from 4.1.2 to 4.1.3

---

a69a6cb09ee0ea1296c3bbd30c66b56f21afb6b6 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/a69a6cb09ee0ea1296c3bbd30c66b56f21afb6b6
Authored: 2024-04-16 17:08:06 -0600
Committed: 2024-04-16 17:09:07 -0600

Avoid a copy

---

2cfa55056cdbcaf724971f26d098fc118fd3f81b by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/2cfa55056cdbcaf724971f26d098fc118fd3f81b
Authored: 2024-03-27 23:21:57 +0000
Committed: 2024-04-15 16:06:19 -0600

[instancer] Switch to doubles for delta calculations.

---

f8ebf27a721daf05fd34215ed661f6e07a7b699e by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/f8ebf27a721daf05fd34215ed661f6e07a7b699e
Authored: 2024-04-15 10:32:58 +0000
Committed: 2024-04-15 06:03:10 -0500

Bump setuptools from 69.2.0 to 69.5.1 in /.ci

---

71200c13418ce0050a84ce7f1ea5a6eafefa31e1 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/71200c13418ce0050a84ce7f1ea5a6eafefa31e1
Authored: 2024-04-15 10:21:59 +0000
Committed: 2024-04-15 06:03:02 -0500

Bump codecov/codecov-action from 4.2.0 to 4.3.0

---

39b5ae79f0e4018ecb004c1a27d6c9f16492f5a5 by Timo Suoranta <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/39b5ae79f0e4018ecb004c1a27d6c9f16492f5a5
Authored: 2024-04-12 17:15:09 +0300
Committed: 2024-04-12 19:33:29 +0200

Fix for #4395

---

c053e8f29257814e11ad61493dbbe29f27656de4 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/c053e8f29257814e11ad61493dbbe29f27656de4
Authored: 2024-04-11 08:58:49 -0600
Committed: 2024-04-11 08:58:49 -0600

[aat] Simplify (or not?) SubtableGlyphCoverage.sanitize()

---

d137d5579908ae29a4fecdc2e31a9987fc0c6c1c by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/d137d5579908ae29a4fecdc2e31a9987fc0c6c1c
Authored: 2024-04-11 08:53:17 -0600
Committed: 2024-04-11 08:53:17 -0600

[aat] Add (unused) SubtableGlyphCoverage

---

d8d2a98b8daa282b28672f5058e1d45c1b6b1fe5 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/d8d2a98b8daa282b28672f5058e1d45c1b6b1fe5
Authored: 2024-04-11 07:45:41 -0600
Committed: 2024-04-11 07:45:41 -0600

[aat] Whitespace

---

b3e4721af7969b1bc46f974107e1f555a96eface by Khaled Hosny <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/b3e4721af7969b1bc46f974107e1f555a96eface
Authored: 2024-04-09 18:54:36 +0200
Committed: 2024-04-09 18:54:36 +0200

Revert "[ci] Enable experimental_api on distcheck job"

---

607931b39612bceac28b3a819517c74ed2e88751 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/607931b39612bceac28b3a819517c74ed2e88751
Authored: 2024-04-08 10:04:44 +0000
Committed: 2024-04-09 08:42:46 -0500

Bump fonttools from 4.50.0 to 4.51.0 in /.ci

---

cd825c9ae8ad834edcf041c35be67112b33ddfe4 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/cd825c9ae8ad834edcf041c35be67112b33ddfe4
Authored: 2024-04-08 10:47:51 +0000
Committed: 2024-04-09 08:42:29 -0500

Bump github/codeql-action from 3.24.9 to 3.24.10

---

51dcc99c872d93d80147573456d146de9a8d11e8 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/51dcc99c872d93d80147573456d146de9a8d11e8
Authored: 2024-04-08 10:47:54 +0000
Committed: 2024-04-09 08:42:17 -0500

Bump codecov/codecov-action from 4.1.1 to 4.2.0

---

c84acc8e0703ee35a2ea15b259a4f04a7b3e5abf by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/c84acc8e0703ee35a2ea15b259a4f04a7b3e5abf
Authored: 2024-04-08 23:46:14 +0000
Committed: 2024-04-09 08:41:32 -0500

[subset] Fix fuzzer found memory leak.

---

89570d195962a4a9fce98eda450a5567782f26d3 by Khaled Hosny <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/89570d195962a4a9fce98eda450a5567782f26d3
Authored: 2024-04-09 01:56:27 +0200
Committed: 2024-04-09 08:41:11 -0500

[ci] Enable experimental_api on distcheck job

---

12dcafe01505f60027e5b30c5e30d4cbce976dd1 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/12dcafe01505f60027e5b30c5e30d4cbce976dd1
Authored: 2024-04-08 22:59:32 +0000
Committed: 2024-04-09 08:41:11 -0500

Add test-hb-subset-parsing.c to extra dist. Needed for meson compile w/ experimental api.

---

f3727c4767262365c232e2fe74d8d96512b3b90e by David Corbett <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/f3727c4767262365c232e2fe74d8d96512b3b90e
Authored: 2024-04-04 19:04:59 -0400
Committed: 2024-04-05 18:35:53 -0600

Recognize ot_languages2’s disambiguation priority

---

2fcace77b2137abb44468a04e87d8716294641a9 by Garret Rieger <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/2fcace77b2137abb44468a04e87d8716294641a9
Authored: 2024-04-02 17:42:14 +0000
Committed: 2024-04-02 11:55:44 -0600

[subet] Don't use experimental api flag in benchmark if not compiled with experimental api.

---

41612df9d378705352e6745c89732563138c150b by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/41612df9d378705352e6745c89732563138c150b
Authored: 2024-04-01 10:57:16 +0000
Committed: 2024-04-01 05:41:06 -0600

Bump actions/setup-python from 5.0.0 to 5.1.0

---

d5d05a9866ec28ba7ab369c069e4fdaeb06b6382 by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/harfbuzz/harfbuzz/commit/d5d05a9866ec28ba7ab369c069e4fdaeb06b6382
Authored: 2024-04-01 10:57:19 +0000
Committed: 2024-04-01 05:40:53 -0600

Bump codecov/codecov-action from 4.1.0 to 4.1.1

---

7de2d11150a8cdfaa5859c845846f5063b6a8197 by Behdad Esfahbod <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/7de2d11150a8cdfaa5859c845846f5063b6a8197
Authored: 2024-04-01 01:54:09 -0600
Committed: 2024-04-01 01:55:38 -0600

Fix autotools test

---

2bd6124737c71df248c6b3af1d201aab93acc428 by Khaled Hosny <[e-mail]>

https://github.com/harfbuzz/harfbuzz/commit/2bd6124737c71df248c6b3af1d201aab93acc428
Authored: 2024-03-30 02:20:21 +0200
Committed: 2024-03-30 02:20:21 +0200

Fix Python warning

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=cfec47ab81dbe8ba5f5842aaaf22ce49f941e4a6

Comment 2

[Update Bot]

Attachment: Bug 1896536 - Update harfbuzz to 8.5.0

Comment 3

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• editing/crashtests/insertparagraph-in-listitem-in-svg-followed-by-collapsible-spaces.html

  • 3 of 4 failed on the same (retriggered) task
    - test-linux2204-64-wayland/debug-web-platform-tests-crashtest (UpjmtT8CSpO-xZPvMbhv2A)
    - test-linux2204-64-wayland/debug-web-platform-tests-crashtest (aLDAI2geR92rko8YTWgyow)
    - test-linux2204-64-wayland/debug-web-platform-tests-crashtest (DIVYvTcVSRqDQXxs2VToGQ)

• layout/reftests/bugs/28811-2a.html == layout/reftests/bugs/28811-2-ref.html

  • 1 of 4 failed on the same (retriggered) task
    - test-android-em-7.0-x86_64-qr/opt-geckoview-reftest-nofis-1 (PIMdrn6LTiSzjxxsk4j1Xw)

• layout/reftests/bugs/28811-2b.html == layout/reftests/bugs/28811-2-ref.html

  • 1 of 4 failed on the same (retriggered) task
    - test-android-em-7.0-x86_64-qr/opt-geckoview-reftest-nofis-1 (PIMdrn6LTiSzjxxsk4j1Xw)

• svg/crashtests/chrome-bug-333487749.html

  • 7 of 8 failed on different tasks
    - test-linux1804-64-qr/debug-web-platform-tests-crashtest (LVjh3SksS6uKhaRxSwv76Q)
    - test-linux1804-64-qr/debug-web-platform-tests-crashtest (c8JLJPgPRjOFMRACdQDcVQ)
    - test-linux1804-64-qr/debug-web-platform-tests-crashtest (dNK3L8FATcCPjoTETi8RRw)
    - test-linux1804-64-qr/debug-web-platform-tests-crashtest (JFinAwMgQeeqlxqElYjiOw)
    - test-linux2204-64-wayland/debug-web-platform-tests-crashtest (UpjmtT8CSpO-xZPvMbhv2A)
    - test-linux2204-64-wayland/debug-web-platform-tests-crashtest (aLDAI2geR92rko8YTWgyow)
    - test-linux2204-64-wayland/debug-web-platform-tests-crashtest (DIVYvTcVSRqDQXxs2VToGQ)

Needs Investigation (Possible Intermittents):

• image/test/reftest/downscaling/downscale-moz-icon-1.html == image/test/reftest/downscaling/downscale-moz-icon-1-ref.html

  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/debug-reftest-swr-nofis-2 (f4hRJdU6TUuX4GtyunHwrQ)

• layout/reftests/css-blending/background-blending-color.html == layout/reftests/css-blending/background-blending-color-ref.svg

  • 1 of 4 failed on the same (retriggered) task
    - test-windows11-64-2009-qr/debug-reftest-wr-dc0-3 (XY_Cf6DnR8SbaRwLk4UBXw)

• layout/reftests/css-blending/background-blending-luminosity.html == layout/reftests/css-blending/background-blending-luminosity-ref.svg

  • 1 of 4 failed on the same (retriggered) task
    - test-windows11-64-2009-qr/debug-reftest-wr-dc0-3 (XY_Cf6DnR8SbaRwLk4UBXw)

• layout/reftests/css-blending/background-blending-overlay.html == layout/reftests/css-blending/background-blending-overlay-ref.svg

  • 1 of 4 failed on the same (retriggered) task
    - test-windows11-64-2009-qr/debug-reftest-wr-dc0-3 (XY_Cf6DnR8SbaRwLk4UBXw)

• layout/reftests/image-element/canvas-outside-document-invalidate-02.html == about:blank

  • 1 of 4 failed on the same (retriggered) task
    - test-windows11-64-2009-qr/debug-reftest-wr-dc0-3 (XY_Cf6DnR8SbaRwLk4UBXw)

• layout/reftests/transform/partial-prerender-in-svg-1.html == layout/reftests/transform/partial-prerender-in-svg-1-ref.html

  • 2 of 4 failed on the same (retriggered) task
    - test-macosx1015-64-qr/debug-reftest-swr-4 (b6tXNuoJTwiToqFV_6fsKg)
    - test-macosx1015-64-qr/debug-reftest-swr-4 (aZaeUYHlSTWz1HuuVUp76Q)

• layout/reftests/transform/partial-prerender-in-svg-2.html == layout/reftests/transform/partial-prerender-in-svg-1-ref.html

  • 2 of 4 failed on the same (retriggered) task
    - test-macosx1015-64-qr/debug-reftest-swr-4 (b6tXNuoJTwiToqFV_6fsKg)
    - test-macosx1015-64-qr/debug-reftest-swr-4 (aZaeUYHlSTWz1HuuVUp76Q)

• layout/reftests/transform/partial-prerender-in-svg-3.html == layout/reftests/transform/partial-prerender-in-svg-3-ref.html

  • 3 of 8 failed on different tasks
    - test-macosx1015-64-qr/debug-reftest-swr-4 (b6tXNuoJTwiToqFV_6fsKg)
    - test-macosx1015-64-qr/debug-reftest-swr-4 (aZaeUYHlSTWz1HuuVUp76Q)
    - test-windows11-64-2009-qr/debug-reftest-wr-dc0-3 (XY_Cf6DnR8SbaRwLk4UBXw)

• layout/reftests/transform/partial-prerender-translate-2.html == layout/reftests/transform/partial-prerender-translate-2-ref.html

  • 4 of 8 failed on different tasks
    - test-macosx1015-64-qr/debug-reftest-swr-4 (b6tXNuoJTwiToqFV_6fsKg)
    - test-macosx1015-64-qr/debug-reftest-swr-4 (aZaeUYHlSTWz1HuuVUp76Q)
    - test-macosx1015-64-qr/debug-reftest-4 (KgYo5RHIR3m-tG6yfGS4Gw)
    - test-macosx1015-64-qr/debug-reftest-4 (bdTYxNUbQk2jQTDpo97QZA)

• layout/reftests/transform/partial-prerender-translate-6.html == layout/reftests/transform/partial-prerender-translate-6-ref.html

  • 2 of 4 failed on the same (retriggered) task
    - test-macosx1015-64-qr/debug-reftest-swr-4 (b6tXNuoJTwiToqFV_6fsKg)
    - test-macosx1015-64-qr/debug-reftest-swr-4 (aZaeUYHlSTWz1HuuVUp76Q)

• layout/reftests/transform/partial-prerender-translate-7.html == layout/reftests/transform/partial-prerender-translate-2-ref.html

  • 2 of 4 failed on the same (retriggered) task
    - test-macosx1015-64-qr/debug-reftest-4 (KgYo5RHIR3m-tG6yfGS4Gw)
    - test-macosx1015-64-qr/debug-reftest-4 (bdTYxNUbQk2jQTDpo97QZA)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor gfx/harfbuzz/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Jonathan Kew [:jfkthame]]

The failures on tryserver all look like intermittents that are unrelated to the library update. I'll review the code but as far as tests are concerned I think it's OK to land.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf33b4cfcbdd
Update harfbuzz to 8.5.0 r=jfkthame

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cf33b4cfcbdd

Comment 7

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf33b4cfcbdd
Update harfbuzz to 8.5.0 r=jfkthame

Perfherder has detected a browsertime performance change from push cf33b4cfcbdd41a9858d3e9d7d5bd4bac0ef93bd.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
3%	speedometer3 Editor-TipTap/Highlight/total	macosx1400-64-shippable-qr	fission webrender	33.34 -> 32.32	Before/After
3%	speedometer3 Editor-TipTap/Highlight/Sync	macosx1400-64-shippable-qr	fission webrender	32.81 -> 31.82	Before/After
3%	speedometer3 Editor-TipTap/total	macosx1400-64-shippable-qr	fission webrender	69.93 -> 67.89	Before/After
3%	speedometer3 Editor-TipTap/Long/Sync	macosx1400-64-shippable-qr	fission webrender	35.75 -> 34.74	Before/After
3%	speedometer3 Editor-TipTap/Long/total	macosx1400-64-shippable-qr	fission webrender	36.58 -> 35.57	Before/After
...	...	...	...	...	...
2%	speedometer3 Editor-TipTap/Highlight/Sync	macosx1400-64-shippable-qr	fission webrender	32.85 -> 32.09	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 354

For more information on performance sheriffing please see our FAQ.