1896600 - Requested server-side settings for MySQL/MariaDB don't work on MariaDB < 10.6

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Dave Miller [:justdave]]

On Ubuntu 20.04:

Checking for              MariaDB (v10.0.5)   ok: found v10.03.3900 

On Ubuntu 22.04:

Checking for              MariaDB (v10.0.5)   ok: found v10.06.1600

So it reports its version numbers without the dot in the middle. We need to check for 10.05 instead of 10.0.5.

Comment 1

[Dave Miller [:justdave]]

OK, nevermind, the 10.0.5 we're looking for would get reported at 10.00.0500, so that's checking properly.
On 10.03.3900 it's complaining about innodb-related settings not being set, even though they are. We're probably testing for them incorrectly.
10.06.1600 does not have that issue.

Comment 2

[Dave Miller [:justdave]]

So the real issue here is that checksetup.pl is complaining that one or more of the following settings are missing:

[mysqld]
innodb_file_format=Baracuda
innodb_file_per_table=1
innodb_large_prefix=1

It turns out that Bugzilla is actually looking for "ON" in those last two, and not "1".
MariaDB >= 10.6 automatically converts the value of innodb_file_per_table to ON if you have 1 in the config file. < 10.6 do not, and it shows as "1" when you read the option if you set it that way in the config.
innodb_large_prefix has been removed in MySQL >= 8 and MariaDB >= 10.6, and Bugzilla properly deals with it being missing and doesn't care if it is, but if it's not missing and it's not set to ON it complains. And likewise, the value is 1 per the config and not ON.

So for MariaDB at least, we need to recommend those be set to ON and not 1 in the config.

I don't know whether that will break MySQL or how MySQL handles that.

Comment 3

[BMO Github Automation]

Attachment: [bugzilla/bugzilla] Bug 1896600: MariaDB <10.6 wants ON instead of 1 in config options (#189)

Comment 4

[BMO Github Automation]

Attachment: [bugzilla/harmony] Bug 1896600: MariaDB <10.6 wants ON instead of 1 in config (#134)

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 9402625 [details] [review]
[bugzilla/bugzilla] Bug 1896600: MariaDB <10.6 wants ON instead of 1 in config options (#189)

removing duplicate

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 9402628 [details] [review]
[bugzilla/harmony] Bug 1896600: MariaDB <10.6 wants ON instead of 1 in config (#134)

removing duplicate

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 9402626 [details] [review]
[bugzilla/bugzilla] Bug 1896600: MariaDB <10.6 wants ON instead of 1 in config options (#189)

Landed on 5.2:
https://github.com/bugzilla/bugzilla/commit/4e53fd8d1b8c7a8087538c4ce48d83420c950c74

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 9402627 [details] [review]
[bugzilla/harmony] Bug 1896600: MariaDB <10.6 wants ON instead of 1 in config (#134)

Landed on Harmony:
https://github.com/bugzilla/harmony/commit/39cddb694110d1acaacd789fde814ef5d8523d68