1896628 - [DNR] Enforce a limit to the maximum number of static rules disabled individually

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to Bug 1810762 we should be enforcing a limit to the maximum number of static rules disabled individually using the new declarativeNetRequest.updateSessionRules API method introduced by Bug 1810762 (as being discussed over phabricator comments here: https://phabricator.services.mozilla.com/D209358#7218578).

Chrome is currently enforcing a 5k limit, but it is currently undocumented and it is not exposed yet as a property of the declarativeNetRequest namespace (like other DNR limits actually are).

We are currently in the process of agreeing with other browser vendors what behavior we want to settle on in the WECG github issue that follows:

• https://github.com/w3c/webextensions/issues/162#issuecomment-2109966158

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1896628 - [DNR] Enforce a limit to the maximum number of static rules disabled individually. r?robwu!

Depends on D211592

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfbda24d068d
[DNR] Enforce a limit to the maximum number of static rules disabled individually. r=robwu

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dfbda24d068d

Comment 4

[rbloor]

Change are ready for review:

• MDN Docs for MAX_NUMBER_OF_DISABLED_STATIC_RULES #34447
• BCD Adds MAX_NUMBER_OF_DISABLED_STATIC_RULES #23533