Closed Bug 1896636 Opened 2 years ago Closed 2 years ago

Remove the crash reporter injector code

Categories

(Toolkit :: Crash Reporting, task)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

The crash reporter injector code was used to inject Breakpad into Flash processes. It's not used anymore and hasn't been for a while. The closest thing we have to it is used by SpiderMonkey but doesn't rely on the in-tree injector (see bug 1522180 comment 3) and we hope to replace it with the OOP generator.

This was used to inject our crash reporting infrastructure into the Flash
processes and has been unused since Flash support has been removed.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f84d1a78c5c Remove the crash reporter injector r=KrisWright

Backed out for causing multiple failures

  • Backout link

  • Push with failures

  • Failure Log 1

  • Failure line: TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/unit_ipc/test_content_annotation.js | xpcshell return code: 0

  • Failure Log 2

  • Failure line: PROCESS-CRASH | application crashed [@ js::ctypes::ConvertToJS] | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_background_early_shutdown.js

  • Failure Log 3

  • Failure line: TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/browser/browser_cpu_microcode.js | contains CPU microcode version -

Also: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8f84d1a78c5cae71b879a33a7aa8528fdf468f7b&searchStr=gv-junit-fis&selectedTaskRun=Wq-pnGlhTbuzLnQ0h5Lhjw.0

Flags: needinfo?(gsvelto)
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c37af59f3ad6 Remove the crash reporter injector r=KrisWright
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Flags: needinfo?(gsvelto)
See Also: → 1897593
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: