1896724 - Fix multi-option for using custom browsertime args that contain a double-dash

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Greg Mierzwinski [:sparky]]

Currently, if you run something like this: /mach raptor -t amazon --verbose --browsertime-arg firefox.geckodriverArgs='--marionette-port' --browsertime-arg firefox.geckodriverArgs=31415

Raptor would split the --marionette-port into a separate option that browsertime parses. Then an empty string gets passed as the geckodriverArg for the first option.

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1896724 - Handle custom browsertime-arg settings that start with a dash. r?#perftest,aglavic

If you run something like this: ./mach raptor -t amazon --verbose --browsertime-arg firefox.geckodriverArgs='--marionette-port' --browsertime-arg firefox.geckodriverArgs=31415

Raptor would split the --marionette-port into a separate option that browsertime parses. Then an empty string gets passed as the geckodriverArg for the first option.

This patch fixes this issue by detecting when the value has a double-dash and passes the option joined with the = instead of split from it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af29dd639cf1
Handle custom browsertime-arg settings that start with a dash. r=aglavic,perftest-reviewers DONTBUILD

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/af29dd639cf1