1896798 - [wpt-sync] Sync PR 46271 - Add allow unload=* to allowlist for frameset frames.

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46271 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46271
Details from upstream follow.

Fergal Daly <[e-mail]> wrote:

Add allow unload=* to allowlist for frameset frames.

With unload deprecation, it becomes impossible to use unload in
\<frame>s because there is no way to set an allow attribute on
them. This change adds an unload=* to their allowlist, meaning that
unload will be allowed if it's allowed in the parent and the child
sets the correct Permissions-Policy header.

Bug: 40286851
Change-Id: I593786ae88683986c740800848de7bfa6a364dd3
Reviewed-on: https://chromium-review.googlesource.com/5540810
WPT-Export-Revision: 72e6111af5c468739f06597926f82194255555e0

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=58399b64d096e7f82abc5650e9a349472f4e1d22

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 6
FAIL : 6

Chrome

OK : 6
PASS : 3
FAIL : 3

Safari

OK : 2
FAIL : 2
TIMEOUT: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /permissions-policy/experimental-features/unload-allowed-embed.tentative.window.html [wpt.fyi]
  • 'unload' Policy : allowed in frames when allowed in main frame.: FAIL (Chrome: FAIL, Safari: TIMEOUT)
• /permissions-policy/experimental-features/unload-allowed-frameset.tentative.window.html [wpt.fyi]
  • 'unload' Policy : allowed in frames when allowed in main frame.: FAIL (Chrome: FAIL, Safari: FAIL)
• /permissions-policy/experimental-features/unload-allowed-object.tentative.window.html [wpt.fyi]
  • 'unload' Policy : allowed in frames when allowed in main frame.: FAIL (Chrome: FAIL, Safari: TIMEOUT)
• /permissions-policy/experimental-features/unload-disallowed-embed.tentative.window.html [wpt.fyi]
  • 'unload' Policy : disallowed in frames when disallowed in main frame.: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /permissions-policy/experimental-features/unload-disallowed-frameset.tentative.window.html [wpt.fyi]
  • 'unload' Policy : disallowed in frames when disallowed in main frame.: FAIL (Chrome: PASS, Safari: FAIL)
• /permissions-policy/experimental-features/unload-disallowed-object.tentative.window.html [wpt.fyi]
  • 'unload' Policy : disallowed in frames when disallowed in main frame.: FAIL (Chrome: PASS, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efd72733a364
[wpt PR 46271] - Add allow unload=* to allowlist for some non-iframe frames., a=testonly
https://hg.mozilla.org/integration/autoland/rev/f193e0bc3971
[wpt PR 46271] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/efd72733a364
https://hg.mozilla.org/mozilla-central/rev/f193e0bc3971