189726 - editorUtilities.js loaded twice when messengercompose.xul called

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[David G King]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030117
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030117

When messengercompose.xul is called it loads editorUtilities.js, however
messengercompose.xul also overlays editorOverlay.xul which itself calls
editorUtilities.js. Thus, editorUtilities.js is being called and compiled twice
rather than just once.

Reproducible: Always

Steps to Reproduce:


Actual Results:  
editorUtilities.js is called twice

Expected Results:  
editorUtilities.js called once

Comment 1

[timeless]

Attachment: right

Comment 2

[David G King]

You got there before me, here I was fighting with "diff", and you've posted the
patch before me.

For future ref, could you eMail me the proper way to create a good and useful diff?

Comment 3

[David G King]

Adding "perf" keyword, although I'm not sure how big a differance this fix will
make.

Comment 4

[David G King]

Comment on attachment 112003 [details] [diff] [review]
right

Altering r and sr to hopefully find someone not ultra busy with 1.3b.

Timeless: I hope you don't mind my doing this.

Comment 5

[(not reading, please use [e-mail] instead)]

makes sense, and I tested the patch and it works.

I'll try to land today.

re-assign to dgk for credit.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 112003 [details] [diff] [review]
right

r/sr=sspitzer

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 112003 [details] [diff] [review]
right

seeking approval

Comment 8

[David G King]

I'm not sure if I should get credit for this, as timeless was the one who
actually submitted the patch (he just got there before me as mentioned in
Comment #2).

Seth: If you can get this landed today, it will be interesting to see what
performance differance it makes. I'll keep an eye on beast and pine and the
delta's on the Ts and Txul's. (Yup, I'm Win32 centric at the moment).

Comment 9

[(not reading, please use [e-mail] instead)]

> I'm not sure if I should get credit for this

ok, I'll re-assign to him

> Seth: If you can get this landed today, it will be interesting to see what
> performance differance it makes. I'll keep an eye on beast and pine and the
> delta's on the Ts and Txul's. (Yup, I'm Win32 centric at the moment).

won't have any affect, as those machines don't bring up the compose window.

but lhasa does, see
http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey-Testerbox

but we aren't gathering Ts or Txul numbers.

are those running generating Ts and Txul numbers on the mailnews smoke test?

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 112003 [details] [diff] [review]
right

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 11

[timeless]

checked in

Comment 12

[David G King]

Verifying. Although this isn't an overly visible bug, at least some more dup
code has been removed, which can only help performance. Thanks to all for the
patch, r, sr and a. Next time I think I'll beat timeless with a patch ;-)