1897292 - `mach event-into-legacy` doesn't generate the correct `telemetry_mirror`

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Chris H-C :chutten]

If you ./mach event-into-legacy browser.launched_to_handle.system_notification you'll be given a decent legacy event definition for browser_launched_to_handle.system_notification. The problem is, you'll be told to add the following property: telemetry_mirror: SystemNotification_Browser_launched_to_handle_Events. Which will fail when you try to compile because the true cpp enum name is Browser_launched_to_handle_SystemNotification_Events

This is due to a couple of problems, but the biggest one is the order of the first to arguments to create_legacy_mirror_def are reversed

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1897292 - Generate the correct event cpp name in event-into-legacy r?TravisLong!

And fix a pylint for overwriting event_category.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76f8ca9a4f69
Generate the correct event cpp name in event-into-legacy r=TravisLong

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/76f8ca9a4f69