189743 - Bad include in layout-debug/plugin

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[timeless]

I:\build\mozilla\debug-i686-pc-cygwin\extensions\layout-debug\plugin>make libs
plugin.cpp
Building deps for i:/build/mozilla/extensions/layout-debug/plugin/plugin.cpp
cl -Foplugin.obj -c -DOSTYPE=\"WINNT5.0\" -DOSARCH=\"WINNT\" -DOJI -I_xpidlgen
-I./include -I../../../dist/include/xpcom -I../../../dist/include/dom
-I../../../dist/include/necko -I../../../dist/include/string
-I../../../dist/include/widget -I../../../dist/include/locale
-I../../../dist/include/view -I../../../dist/include/pref
-I../../../dist/include/imglib2 -I../../../dist/include/unicharutil
-I../../../dist/include/java -I../../../dist/include/debug
-I../../../dist/include/plugin -I../../../dist/include/npdebug
-I../../../dist/include -I../../../dist/include/nspr           -TP -W3 -nologo
-Gy -Fdnpdebug.pdb  -DDEBUG -D_DEBUG -DDEBUG_Administrator -DTRACING -Zi
/DEF:npdebug.def -DWIDGET_DLL=\"gkwidget.dll\" -DGFXWIN_DLL=\"gkgfxwin.dll\"  
-MDd           -DHAVE_MMINTRIN_H=1 -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -D_WIN32=1
-DWIN32=1 -DXP_PC=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DWINVER=0x400
-DMSVC4=1 -DSTDC_HEADERS=1 -DNEW_H=\<new\> -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1
-D_X86_=1 -DD_INO=d_ino -DMOZ_DEFAULT_TOOLKIT=\"windows\"
-DMOZ_ENABLE_COREXFONTS=1 -DIBMBIDI=1 -DMOZ_MATHML=1 -DMOZ_LOGGING=1
-DFORCE_BUILD_REFCNT_LOGGING=1 -DDETECT_WEBSHELL_LEAKS=1 -DMOZ_TIMELINE=1
-DMOZ_REFLOW_PREF=1 -DMOZ_PERF_METRICS=1 -DNS_TRACE_MALLOC=1
-DMOZ_USER_DIR=\".mozilla\" -DCPP_THROW_NEW=throw\(\) -DMOZ_XUL=1
-DINCLUDE_XUL=1 -DNS_MT_SUPPORTED=1 -DMOZ_DLL_SUFFIX=\".dll\" -DXP_PC=1
-DJS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1 -DMOZ_REFLOW_PERF=1
-DMOZ_REFLOW_PERF_DSP=1  -DMOZILLA_CLIENT
i:/build/mozilla/extensions/layout-debug/plugin/plugin.cpp
plugin.cpp
i:/build/mozilla/extensions/layout-debug/plugin/plugin.h(41) : fatal error
C1083: Cannot open include file: 'pluginbase.h': No such file or directory
make: *** [plugin.obj] Error 2

You can't do -I./plugin because it breaks objdir builds :)

Comment 1

[timeless]

Attachment: fix makefile (objdir issues) and resource file (afxres is annoying)

the makefile changes are correct.
i don't have afxres and you never actually need it, it just pulls in winnt.h

Comment 2

[Bernd]

Comment on attachment 112027 [details] [diff] [review]
fix makefile (objdir issues) and resource file (afxres is annoying)

r=bernd, sorry I had the same patch (minus the afx issue in my tree)

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

->timeless, cc:sfraser

Comment 4

[kinmoz]

Comment on attachment 112027 [details] [diff] [review]
fix makefile (objdir issues) and resource file (afxres is annoying)

sr=[e-mail] on the Makefile.in changes ... I'm just not familiar enough
with the .rc format to know if your modifications are ok?

Comment 5

[Simon Fraser [no longer active]]

this entire directory is going away. don't bother with it.

Comment 6

[timeless]

i'm trying to get bugs off my radar. the rc change is correct.

Comment 7

[timeless]

.