1897529 - Use moz-checkbox and moz-fieldset for Sidebar Settings

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P2)

Description

[Mark Striemer [:mstriemer]]

Once we have bug 1894486 and bug 1894487 landed we should update the Sidebar Settings to use the moz-fieldset and moz-checkbox

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1897529 - Part 1: Support name and click() in moz-checkbox r?#recomp-reviewers

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1897529 - Part 1: Support name and click() in moz-checkbox r?#recomp-reviewers

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r?#sidebar-reviewers

Depends on D213319

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c52e2ac9df2
Part 1: Support name and click() in moz-checkbox r=reusable-components-reviewers,hjones
https://hg.mozilla.org/integration/autoland/rev/efaba56826e3
Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones

Comment 5

[tszentpeteri]

Backed out for causing mochitest failures on test_moz_message_bar.html and on browser_a11y_sidebar.js

• Backout link
• Push with failures
• Failure Log for sidebar
• Failure Log for message bar:

[task 2024-06-14T02:56:51.190Z] 02:56:51     INFO - TEST-PASS | toolkit/content/tests/widgets/test_moz_message_bar.html | Info icon is showing up. 
[task 2024-06-14T02:56:51.191Z] 02:56:51     INFO - Buffered messages finished
[task 2024-06-14T02:56:51.192Z] 02:56:51     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_moz_message_bar.html | Alternate text for the info icon is present. - got "", expected "Info"
[task 2024-06-14T02:56:51.192Z] 02:56:51     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:509:14
[task 2024-06-14T02:56:51.192Z] 02:56:51     INFO - test_component_declaration@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_message_bar.html:33:9
[task 2024-06-14T02:56:51.193Z] 02:56:51     INFO - add_task/nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2189:34
[task 2024-06-14T02:56:51.193Z] 02:56:51     INFO - nextTick@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2233:11
[task 2024-06-14T02:56:51.194Z] 02:56:51     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:922:41
[task 2024-06-14T02:56:51.194Z] 02:56:51     INFO - add_task@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2137:17
[task 2024-06-14T02:56:51.194Z] 02:56:51     INFO - @chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_message_bar.html:24:13
[task 2024-06-14T02:56:51.196Z] 02:56:51     INFO - TEST-PASS | toolkit/content/tests/widgets/test_moz_message_bar.html | Heading is showing up. 

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d654154d5ea
Part 1: Support name and click() in moz-checkbox r=reusable-components-reviewers,hjones
https://hg.mozilla.org/integration/autoland/rev/3d631de2ce01
Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones
https://hg.mozilla.org/integration/autoland/rev/334b820a4c19
1900126, 1901336: apply code formatting via Lando

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_a11y_sidebar.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f32af8e7b2d8e50f7a67462367ec346dc12817a0

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_a11y_sidebar.js | Uncaught exception in test bound test_menu_items_labeled

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aad9d2c26ac
Part 1: Support name and click() in moz-checkbox r=reusable-components-reviewers,hjones
https://hg.mozilla.org/integration/autoland/rev/413db7a85f97
Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9aad9d2c26ac
https://hg.mozilla.org/mozilla-central/rev/413db7a85f97