1897599 - Update opus to new version eb39efaa154fab96bf12b5cab932418cd3807eb2 from 2024-05-18 02:54:24

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 3 commits. Here are the overall diff statistics, and then the commit information.

---

media/libopus/moz.build | 2 +-
media/libopus/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

eb39efaa154fab96bf12b5cab932418cd3807eb2 by Jean-Marc Valin <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/eb39efaa154fab96bf12b5cab932418cd3807eb2
Authored: 2024-05-05 23:04:48 -0400
Committed: 2024-05-18 02:54:24 -0400

Fixing lossgen to work with USE_WEIGHTS_FILE

Retraining a new model so that we have a matching .pth file.
Also, discarding more data on init to get better randomization.

Files Added:

• tar_list.txt

Files Modified:

• autogen.sh
• dnn/lossgen.c

---

0e564fdfafc2d4fe8261af7bd691d486947ab534 by Jean-Marc Valin <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/0e564fdfafc2d4fe8261af7bd691d486947ab534
Authored: 2024-05-18 02:40:53 -0400
Committed: 2024-05-18 02:40:53 -0400

More fixes for the non-blob weight export

Files Modified:

• dnn/torch/lossgen/export_lossgen.py
• dnn/torch/weight-exchange/wexchange/c_export/common.py

---

1711e971655439c02423ceeec58e3078d2eee5a3 by Jan Buethe <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/1711e971655439c02423ceeec58e3078d2eee5a3
Authored: 2024-05-06 14:11:59 +0200
Committed: 2024-05-06 14:11:59 +0200

fixed enable_binary_blob option for CWriter

Files Modified:

• dnn/torch/lossgen/export_lossgen.py
• dnn/torch/weight-exchange/wexchange/c_export/c_writer.py
• dnn/torch/weight-exchange/wexchange/c_export/common.py

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=88c3900f1a8b8538842c50fe3108e4777b451daf

Comment 2

[Update Bot]

Attachment: Bug 1897599 - Update opus to eb39efaa154fab96bf12b5cab932418cd3807eb2

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37f6aa1cb109
Update opus to eb39efaa154fab96bf12b5cab932418cd3807eb2 r=kinetik DONTBUILD

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/37f6aa1cb109